[cmake-developers] Review request: extract-cmMessenger branch

[Stephen Kelly]

On 06/13/2016 04:22 PM, Brad King wrote:
> On 06/11/2016 08:14 AM, Stephen Kelly wrote:
>> Thanks for your thorough review! I think I've fixed the errors I
>> introduced while rebasing now.
>>
>> I'm not completely certain that the gymnastics I do with the
>> cmListFileBacktrace in the parser in the early commits in the branch are
>> correct or appropriate.
> The role of `.Pop()` on `lfbt = this->Backtrace.Pop()` is not clear.
> I was not able to produce a RunCMake.Syntax test failure by removing it.
>
> The clean-up-Parser topic currently strips the backtrace lines and some
> other context from some expected test output even though the lines still
> appear, such as in
>
>   Tests/RunCMake/Syntax/UnterminatedBracket0-stderr.txt
>
> and I think a few others.  Please restore the context lines where possible.
>
> Overall I like the cleanup though.

You're right, but I think digging into that again would take more time
than I want to put into it now. I really just wanted to not have to
rebase that branch again in the future :).

I've merged other clean ups and pushed the rest of the
extract-cmMessenger branch to my repo again.

Thanks,

Steve.