[cmake-developers] Review request: extract-cmMessenger branch

Stephen Kelly steveire at gmail.com
Sat Jun 11 08:14:47 EDT 2016


On 06/10/2016 10:07 PM, Daniel Pfeifer wrote:
> On Fri, Jun 10, 2016 at 8:17 PM, Stephen Kelly <steveire at gmail.com> wrote:
>> However, that's not a problem when messages are delivered through the
>> daemon, so I suggest that
>>
>>  https://github.com/steveire/cmake/tree/extract-cmMessenger
>>
>> and the daemon itself are good places to direct your attention to improve
>> this situation.
> I have reviewed the branch and wrote some inline comments on github.
> Overall, I confirm this is the right approach. So, "approval" from my side.

Thanks for your thorough review! I think I've fixed the errors I
introduced while rebasing now.

I'm not completely certain that the gymnastics I do with the
cmListFileBacktrace in the parser in the early commits in the branch are
correct or appropriate.

Thanks,

Steve.



More information about the cmake-developers mailing list