[cmake-developers] CPack/NSIS is broken after extended length paths fix

[Dmitry Kochkin]

 Hi Clint,

>>Actually it's even worse because in current master HEAD I can see that INST_DIR is empty in generated project:
>>  !define INST_DIR ""
>>(not sure if that's caused by your change)
>Interesting... Do you know why this happens?  How is this problem related to extended paths (with the \\?\ prefix)?  Do you have an example to demonstrate this problem? That was my mistake, please ignore.
>>I've figured out that NSIS was not going to fix this (see  http://sourceforge.net/p/nsis/feature-requests/241/ )
>
>Maybe they'll accept a patch to fix it there?  Was there any effort to fix it there?
In the URL I've put they claim you should just use "\\?\" in your NSIS project.
I guess it's also possible to fix NSIS, but we cannot rely that user have latest NSIS.

>
>>
>>I've made a small patch to NSIS generator and template to put infamous \\?\ there.
>>
>>I can send directly to you as I guess you know more about these parts of code.
>
>You can send your patch to this mailing list for review.
Patch attached. It's a bit hacky, more fixing symptoms I guess. The purpose is only to demonstrate the idea.
Let me know if it can be done in better way.

Regards,
Dmitry


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/cmake-developers/attachments/20150921/e6b88023/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: nsis_fix.patch
Type: application/x-patch
Size: 2773 bytes
Desc: not available
URL: <http://public.kitware.com/pipermail/cmake-developers/attachments/20150921/e6b88023/attachment.bin>