[cmake-developers] Add CXX_STANDARD support for Intel C++ compilers

[Levi Morrison]

On Mon, Nov 30, 2015 at 11:33 AM, Brad King <brad.king at kitware.com> wrote:
> On 11/30/2015 01:18 PM, Levi Morrison wrote:
>> My latest patch is attached. All tests seem to be working for me on
>> the compiler versions I have access to. Can you check it for any
>> glaring errors?
>
> Good.  This hunk:
>
>> +  if (NOT CMAKE_CXX_COMPILER_FORCED)
>> +    if (NOT CMAKE_CXX_STANDARD_COMPUTED_DEFAULT)
>> +      set(CMAKE_CXX_STANDARD_DEFAULT 98)
>> +    else()
>> +      set(CMAKE_CXX_STANDARD_DEFAULT ${CMAKE_CXX_STANDARD_COMPUTED_DEFAULT})
>> +    endif()
>> +  endif()
>
> still needs to be revised to account for recent changes:
>
>  Project: Guess default standard dialect if compiler was forced (#15852)
>  https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=441dba80
>
> If CMAKE_CXX_COMPILER_FORCED is set then we now fall back to a guess.
> Otherwise it is an error for CMAKE_CXX_STANDARD_COMPUTED_DEFAULT to
> not be set.
>
> Thanks,
> -Brad
>

Hmm. This was done already. Seems I just miscopied the patch again. I
don't know how many times I'll make this mistake before I quit doing
it :D.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Add-CXX_STANDARD-support-to-Intel-C-compilers.patch
Type: application/octet-stream
Size: 12012 bytes
Desc: not available
URL: <http://public.kitware.com/pipermail/cmake-developers/attachments/20151130/8c656591/attachment-0001.obj>