[cmake-developers] Add CXX_STANDARD support for Intel C++ compilers

Levi Morrison morrison.levi at gmail.com
Tue Nov 17 15:57:49 EST 2015


On Tue, Nov 17, 2015 at 1:23 PM, Levi Morrison <morrison.levi at gmail.com>
wrote:

> > I'm not sure how to edit Tests/CompileFeatures/CMakeLists.txt, though.
>> > I don't even know what half of this file is trying to accomplish.
>> > It seems like it is pure duplication of work; these checks are saying
>> > EXPECT_C_STATIC_ASSERT=1 if some compiler conditions are true but
>> > I already encoded that information in Intel-CXX-FeatureTests.cmake
>>
>> It is duplicated because the test memorizes the answers to make sure
>> the detection works for known cases.  The EXPECT_... definitions
>> encode the expected results for the HAVE_... definitions that are
>> set by the $<COMPILE_FEATURES:...> generator expressions.  This
>> way the test ensures that the detection works and its results
>> propagate all the way through genex evaluation correctly.
>>
>> > In any case, it seems I still need to update something
>>
>> Please post the patch so far so we can look at it to see what may be
>> missing.  Once this part works then it may activate the real parts
>> of the CompileFeatures test and lead you to the portions of that test
>> that need to be filled in for the Intel compiler.
>>
>> Thanks,
>> -Brad
>>
>>
> Attached is the patch. I'm unsure if the `&& __INTEL_CXX11_MODE__` parts
> are needed. I was hoping I'd find out when running tests.
>

Also, it is worth pointing out that some of the features are partially
supported in earlier versions, but in the FeatureTests.cmake I put it only
for the first version that claims complete compatibility – is that the
correct action?
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/cmake-developers/attachments/20151117/145f65ac/attachment.html>


More information about the cmake-developers mailing list