[cmake-developers] FW: FW: Initial Attempt at Green Hill MULTI IDE Generator Support

Brad King brad.king at kitware.com
Tue Mar 24 14:00:28 EDT 2015


On 03/24/2015 11:54 AM, Brad King wrote:
> I added some more commits to tweak a few things too:

And a few more to fix our continuous testing results:

 GHS: Do not use C++11 enum name scope
 http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=a4427fa9

 GHS: Use !foo.empty() instead of foo.size() > 0
 http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=54828b82

 GHS: Do not use string::back() that is missing on VS 7.1
 http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=dbc9f8c6

> I will squash all those in once you've okay-ed them and we've finished
> the topic with clean nightly testing.
> 
> Meanwhile, please continue work based on commit ed1ee3d4 and send
> patches against that.  In particular, please convert the C++ coding
> style as follows:
> 
> * Use "this->" on all member accesses inside methods.
> * Place "{" on its own line indented with the content inside the
>   block.
> 
> This is the style used in the rest of CMake so it will be more
> consistent to maintain that way.

Please do this based on commit dbc9f8c6 instead.

Also, several of the places that test for and add a trailing slash
could be ported to use ConvertToUnixSlashes instead.  That always
removes trailing slashes and would also fix any backslashes specified
by project code in property values.

Thanks,
-Brad



More information about the cmake-developers mailing list