[cmake-developers] Introduction and volunteering for the Matlab package
Brad King
brad.king at kitware.com
Thu Mar 12 16:00:33 EDT 2015
On 03/12/2015 12:35 PM, Raffi Enficiaud wrote:
>> Please find the attached patch addressing the issues. In the current
>> implementation, if the Matlab_ROOT_DIR is changed by the user, the
>> cached variables are all cleared.
>> Also, Matlab_ROOT_DIR is now the only variable that is seen as non
>> advanced.
>
> The attached patch replaces the previous one: now the versions on
> Windows are ordered starting the most recent (+ an ugly remaining
> FATAL_ERROR debug).
Great. I applied that on top of where we last left off and
then rebased on 'master' to resolve conflicts. I also made
a couple minor tweaks:
* Renamed one more MATLAB_USER_ROOT => Matlab_ROOT_DIR
* Do not call list(REMOVE_DUPLICATES/SORT/REVERSE) with no list
The commits are now:
FindMatlab: Rewrite module and provide a usage API
http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=3c025a5f
FindMatlab: Further revisions
http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=842ab109
FindMatlab: Further revisions
http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=3743aa11
I will squash all this together once everything is done.
For now please base further work on commit 3743aa11.
We'll see how this does on the nightly testing!
Thanks,
-Brad
More information about the cmake-developers
mailing list