[cmake-developers] Java support

[CHEVRIER, Marc]

New version of patches taking into account Brad’ remarks.

Marc




On 29/07/15 15:47, "Brad King" <brad.king at kitware.com> wrote:

>On 07/29/2015 04:01 AM, CHEVRIER, Marc wrote:
>> here is an updated list of patches.
>
>Great.
>
>>    find_package_handle_standard_args(Java
>>      REQUIRED_VARS Java_JAVA_EXECUTABLE Java_JAR_EXECUTABLE Java_JAVAC_EXECUTABLE
>>                    Java_JAVAH_EXECUTABLE Java_JAVADOC_EXECUTABLE
>> +                  Java_IDLJ_EXECUTABLE Java_JARSIGNER_EXECUTABLE
>>      VERSION_VAR Java_VERSION
>>      )
>
>Are idlj and jarsigner reliably available whenever the other tools are?
>Even for older versions?  Do these need to be REQUIRED_VARS?  I'm
>concerned this could make a case that previously found java not report
>it found anymore.
>
>> -          --build-project hello
>> +          --build-target hello
>
>The tests should still have --build-project as this corresponds to
>the .sln file name in Visual Studio builds.  The --build-target
>option can be added in addition to it.
>
>Thanks,
>-Brad
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Add-support-for-idlj-and-jarsigner-tools.patch
Type: application/octet-stream
Size: 5623 bytes
Desc: 0001-Add-support-for-idlj-and-jarsigner-tools.patch
URL: <http://public.kitware.com/pipermail/cmake-developers/attachments/20150730/711978b3/attachment-0004.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-add_jar-now-supports-file-syntax-for-sources.patch
Type: application/octet-stream
Size: 6120 bytes
Desc: 0002-add_jar-now-supports-file-syntax-for-sources.patch
URL: <http://public.kitware.com/pipermail/cmake-developers/attachments/20150730/711978b3/attachment-0005.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-install_jar-add-options-DESTINATION-and-COMPONENT.patch
Type: application/octet-stream
Size: 3564 bytes
Desc: 0003-install_jar-add-options-DESTINATION-and-COMPONENT.patch
URL: <http://public.kitware.com/pipermail/cmake-developers/attachments/20150730/711978b3/attachment-0006.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-Add-support-for-javah-tool.patch
Type: application/octet-stream
Size: 9631 bytes
Desc: 0004-Add-support-for-javah-tool.patch
URL: <http://public.kitware.com/pipermail/cmake-developers/attachments/20150730/711978b3/attachment-0007.obj>