[cmake-developers] Listing source-tree files encountered

Brad King brad.king at kitware.com
Tue Jul 21 12:33:30 EDT 2015


On 07/21/2015 11:57 AM, Clifford Yapp wrote:
> The attached patch seems to work - Brad, should I submit this to the
> issue tracker?  If it needs any more tweaking let me know.

No issue tracker entry needed.  CONTRIBUTING.rst explains that the
mailing list is preferred.  I'll take a look at this when I get a
chance.

> Looking at the target properties test, should there also be a test for
> the SOURCES property?  The SOURCE_DIR property in particular is
> intended to work with the current behavior (relative path lists unless
> original target specifier is a full path) from SOURCES, so IMHO it
> might be a good idea to put a test in for that as well...

There is some coverage of the SOURCES property in other tests but
having a dedicated check for it would be worthwhile too.

Thanks,
-Brad




More information about the cmake-developers mailing list