[cmake-developers] [PATCH] Fix a few issues in FindHDF5 module

[Paul Romano]

Thanks for the suggestions, Brad. Here is a set of three patches that
breaks out the changes. For the HDF5_PREFER_PARALLEL implementation, I now
use a list to set the names for find_program which does look much cleaner.
I agree that having a NAMES_PER_DIR for find_program would be simpler from
the user's end. However, as I'm unfamiliar with the C++ source, it would
take me much longer to figure out how to add the necessary changes, so I'll
leave you with the module patches for now.

Best,
Paul

On Tue, Sep 1, 2015 at 1:53 AM, Brad King <brad.king at kitware.com> wrote:

> On 08/31/2015 04:47 AM, Paul Romano wrote:
> > I'd like to offer the attached patch for consideration
>
> Thanks for working on these changes.
>
> Please split each independent fix out into its own commit with
> corresponding commit message explaining the change.
>
> For the HDF5_PREFER_PARALLEL implementation, please re-use
> the existing find_program calls but simply prepare a variable
> ahead of time that lists the preferred order of names.  OTOH,
> there is another approach to solve this.  The find_library
> command has a NAMES_PER_DIR option that says to consider all
> the given names in each directory before moving on to the next
> directory.  If find_program had this too then one would be able
> to choose a preference simply by having one come first in PATH.
>
> -Brad
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/cmake-developers/attachments/20150901/738d47f9/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-FindHDF5-Bring-patch-from-debian-cmake-data-package-.patch
Type: text/x-patch
Size: 1173 bytes
Desc: not available
URL: <http://public.kitware.com/pipermail/cmake-developers/attachments/20150901/738d47f9/attachment-0003.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-FindHDF5-Add-hdf5_hl-to-list-of-libraries-to-search-.patch
Type: text/x-patch
Size: 1192 bytes
Desc: not available
URL: <http://public.kitware.com/pipermail/cmake-developers/attachments/20150901/738d47f9/attachment-0004.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-FindHDF5-Introduce-HDF5_PREFER_PARALLEL-option-to-ad.patch
Type: text/x-patch
Size: 2766 bytes
Desc: not available
URL: <http://public.kitware.com/pipermail/cmake-developers/attachments/20150901/738d47f9/attachment-0005.bin>