[cmake-developers] [PATCH] Fix error in compiling C++ files generating by protobuf compiler when .proto files are organized in a directory hierarchy

[ابراهیم محمدی]

${FILE_PATH} is PATH part of ${FIL} and ${FIL} is path of each of .proto
files relative to CMakeLists.txt as the user has entered in CMakeLists.txt.
So ${FIL} and consequently ${FILE_PATH} cannot contain drive letters in a
genuine usage scenario. Or I'm missing something.


On Mon, May 26, 2014 at 3:45 PM, David Cole <dlrdave at aol.com> wrote:

> > Hi everybody there,
> >
> > Subject says it all. See the attached patch please.
> >
> > (Didn't care enough to leave hg for git to generate the patch. Sorry.)
>
>
> FILE_PATH is likely to contain "C:" or some other drive letter on
> Windows. It is therefore unsuitable for using to construct a sub-path
> underneath CMAKE_CURRENT_BINARY_DIR.
>
> You don't have to care enough to leave hg, but we do have to care
> enough to make sure CMake still works on all the platforms it's
> intended to work on.
>
> This patch may fix your particular use case, but it is not generally
> correct, and therefore, unlikely to be adopted into upstream CMake.
> There must be a better solution, that will work on all platforms...
>
>
> David C.
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/cmake-developers/attachments/20140526/8adfc30a/attachment-0002.html>