[cmake-developers] [PATCH 2/2] Ninja: Fix failing CMakeLib.testRST test

Brad King brad.king at kitware.com
Fri Jun 6 10:49:02 EDT 2014


On 06/06/2014 10:12 AM, Sam Spilsbury wrote:
> Ninja was passing a relative path to the compiler which causes
> __FILE__ to use that same relative path. This was causing the test to
> fail, because Ninja is not a recursive generator and so __FILE__
> differed between generators.
> 
> For the sake of consistency, an absolute path should always be passed
> to the compiler on each generator, so that __FILE__ is always
> consistent.

This is a larger debate for those that develop and use the Ninja
generator.  For now let's just fix the test to not depend on a
full path to __FILE__:

 Tests: Fix CMakeLib.testRST for relative __FILE__
 http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=218699eb

-Brad




More information about the cmake-developers mailing list