[cmake-developers] [PATCH] Avoid bad alloc for large files

[Rolf Eike Beer]

Am Dienstag, 23. Dezember 2014, 10:27:47 schrieb Rolf Eike Beer:
> Am Montag, 22. Dezember 2014, 22:16:50 schrieb Rolf Eike Beer:
> > Am Montag, 22. Dezember 2014, 10:50:28 schrieb Brad King:
> > > On 12/20/2014 08:44 AM, Rolf Eike Beer wrote:
> > > > This is basically the same, but it avoids the needless floating point
> > > > arithmetic. Does it work for you?
> > > 
> > > Thanks, Eike.  Please add a topic to put this in 'next' when ready.
> > 
> > Done. I wonder if we should not check for new returning null?
> 
> Ok, now I get this:
> 
> cmCTest.cxx
> C:\Dashboards\My Tests\CMakeNext-vs12-64-ninja-src\Source\cmCTest.cxx(1705)
> : warning C4267: 'argument' : conversion from 'size_t' to 'unsigned long',
> possible loss of data
> 
> The problem is: this is absolutely right. On Windows64 this means that the
> maximum file size will be 4GB, or one needs to change the base64
> implementation. Which way to go?

*lol*

From: "Brad King (Code Review)" <review at kitware.com>
Date: Tue, 23 Dec 2014 04:27:55 -0500
Subject: Change in KWSys[master]: Base64: Use size_t for lenghts in API
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://public.kitware.com/pipermail/cmake-developers/attachments/20141223/1cb641ad/attachment.sig>