[cmake-developers] Volunteering to maintain a new module: FindGSL.cmake

[Thompson, KT]

Brad,

I made the changes that you suggested wrt removing trailing whitespace and removing variables from the cache. I also reverted a recent change by replacing GSL_CONFIG_EXECUTABLE with GSL_CONFIG to remain consistent with the naming conventions of PkgConfig.cmake. The updated FindGSL.cmake is attached.

I also created a simple test for the new module (see attached FindGSL.tgz).  If ENABLE_FINDGSL_TEST is true, this test will be included.  I am setting up a nightly cmake regression on one of my machines that will run this test. In addition to the new files found in FindGSL.tgz, the Tests/CMakeLists.txt will require this simple addition:

--- a/Tests/CMakeLists.txt
+++ b/Tests/CMakeLists.txt
@@ -1252,6 +1252,11 @@ ${CMake_BINARY_DIR}/bin/cmake -DDIR=dev -P ${CMake_SOURCE_DIR}/Utilities/Release
     add_subdirectory(FindGTK2)
   endif()
 
+  find_package(GSL QUIET)
+  if(GSL_FOUND AND ENABLE_FINDGSL_TEST)
+    add_subdirectory(FindGSL)
+  endif()
+
   add_test(ExternalProject ${CMAKE_CTEST_COMMAND}
     --build-and-test
     "${CMake_SOURCE_DIR}/Tests/ExternalProject"

I can build build and test cmake with my new tests in my local sandbox so I have some confidence that the test is working as intended.  I don't know how to check the testing code in the cmake regression system w/o it being checked into git.

Let me know how I should proceed.

-kt

-------------- next part --------------
A non-text attachment was scrubbed...
Name: FindGSL.cmake
Type: application/octet-stream
Size: 9500 bytes
Desc: FindGSL.cmake
URL: <http://public.kitware.com/pipermail/cmake-developers/attachments/20141216/5cce9419/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: FindGSL.tgz
Type: application/x-compressed
Size: 952 bytes
Desc: FindGSL.tgz
URL: <http://public.kitware.com/pipermail/cmake-developers/attachments/20141216/5cce9419/attachment.bin>