[cmake-developers] Initial Attempt at Green Hill MULTI IDE Generator Support

[Geoffrey Viola]

Thanks for the feedback. Sorry for the late response. I won't be able to make another patch for another 3 weeks.

I would like to take care of some bugs first. There is a bug where GHS MULTI is not recompiling executables and libraries, when compiling a .elf file. Also, the generator will need to be able to set the output filename and use the output directory.

It's good to hear that there are tests. I'm not sure how I missed them.


Geoffrey Viola
SOFTWARE ENGINEER
T

+1.435.755.2980

ext 1077
M

+1.215.896.6521


asirobots.com




-----Original Message-----
From: Brad King [mailto:brad.king at kitware.com]
Sent: Tuesday, November 25, 2014 1:06 PM
To: Geoffrey Viola
Cc: cmake-developers at cmake.org
Subject: Re: [cmake-developers] Initial Attempt at Green Hill MULTI IDE Generator Support

On 11/17/2014 05:16 PM, Geoffrey Viola wrote:
> I made some changes and rebased on the trunk.

Thanks.  Here are a few minor comments:

* The hunk in Modules/CMakeDetermineCompilerId.cmake is now just a
  whitespace change, so please drop it.

* Please ensure C++ sources do not have lines exceeding 79 columns.

* Please avoid trailing whitespace on source lines.

Next we need to add tests.  Since CMake won't build with this generator we need to add tests using the generator as part of the test suite when the needed tools are available.  Look in Tests/CMakeLists.txt for uses of add_test_VSWinStorePhone as an example of how this is done for another target platform.
You can either add a new test directory with dedicated code covering capabilities of the generator, or re-use some of the existing tests to see if they build under the new generator, or both.

Once you get tests working, please look at submitting an experimental build to our dashboard and posting a link to it.
You can do that from the build tree of CMake with

  ctest -C Debug -D Experimental

(or with whatever configuration you built locally).

Thanks,
-Brad
This message contains confidential information and is intended only for the recipient. If you are not the named addressee you should not disseminate, distribute or copy this e-mail. Please notify the sender immediately if you have received this e-mail by mistake and delete this e-mail from your system. Finally, the recipient should check this email and any attachments for the presence of viruses. The company accepts no liability for any damage caused by any virus transmitted by this email.