[cmake-developers] Patch pull request: support for shader entry point and shader model for Visual Studio FXCompiler custom tool build

[Brad King]

On 11/29/2014 12:51 AM, Cedric Perthuis wrote:
> So, here's a patch to address this. 
[snip]
> +    if (const char* se = sf->GetProperty("VS_SHADER_ENTRY_POINT"))
[snip]
> +    if (const char* sm = sf->GetProperty("VS_SHADER_MODEL"))

Thanks.  Here are some comments on the patch:

* Please update the documentation too.  See

   Help/manual/cmake-properties.7.rst
   Help/prop_sf/VS_SHADER_TYPE.rst

  for how VS_SHADER_TYPE is documented.

* Please update the test.  See

   Tests/VSWinStorePhone/CMakeLists.txt

  for current testing of VS_SHADER_TYPE.

Thanks,
-Brad