[cmake-developers] [Review request] Topic ExternalProject_TEST_EXCLUDE_FROM_MAIN

Brad King brad.king at kitware.com
Mon Dec 1 10:03:48 EST 2014


On 11/30/2014 04:38 PM, Daniele E. Domenichelli wrote:
> * ExternalProject: Add TEST_EXCLUDE_FROM_MAIN option
>   http://www.cmake.org/gitweb?p=stage/cmake.git;a=commitdiff;h=ced29ab

LGTM.  Please also add a

 Help/release/dev/ExternalProject_TEST_EXCLUDE_FROM_MAIN.rst

file with a release note advertising the feature.  This step is
now covered in the instructions here:

 http://www.cmake.org/Wiki/CMake/Git/Develop#Create_a_Topic
 "If your change is user-facing please create a
  Help/release/dev/my-topic.rst document with release notes."

Thanks,
-Brad



More information about the cmake-developers mailing list