[cmake-developers] Review request: Qt-auto-generators
Alexander Neundorf
neundorf at kde.org
Thu Oct 24 13:30:43 EDT 2013
On Thursday 24 October 2013, Stephen Kelly wrote:
> Hi,
>
> I've pushed the Qt-auto-generators topic to stage. This topic was discussed
> here:
>
> http://thread.gmane.org/gmane.comp.programming.tools.cmake.devel/7936
>
> I have tested it with ports of KDE Frameworks and GammaRay to use the
> features.
>
> Alex, could you also review the topic please?
Looks good in general.
Just some nitpicking: this is still Qt-specific, so I would prefer to have
something related to Qt in the names of the target properties and output and
maybe also if the generated files instead of AUTOGEN_TARGETS_FOLDER,
"AUTOGEN:" and and AutogenInfo.cmake.
Alex
More information about the cmake-developers
mailing list