[cmake-developers] Perforce Patch for CTest

Brad King brad.king at kitware.com
Wed Oct 23 16:49:56 EDT 2013


On 10/22/2013 06:11 PM, Pedro Navarro wrote:
> Good point :) Here's the new patch.

Great, thanks!  I've applied it:

 http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=c63ecee3

with minor tweaks:

* Updated commit author date to when you sent the email
* Wrote more extensive commit message
* Marked P4_EXECUTABLE as an advanced cache option
* Simplified the cygwin exclusion logic for adding the test
* Quoted the p4d shell command args to support spaces in path

I also downloaded the p4 and p4d binaries and put them on
the hythloth.kitware dashboard machine so they should run as
part of its Linux64-gnu test tonight.  I used them to run the
test locally and it works for me :)

Great work,
-Brad



More information about the cmake-developers mailing list