[cmake-developers] Perforce Patch for CTest

[Rolf Eike Beer]

Am Dienstag, 22. Oktober 2013, 14:36:36 schrieb Pedro Navarro:
> Attached is the new patch with Eike's recommendations.

One more nitpick ;)

+  this->OldRevision = this->GetWorkingRevision();
+  if(this->OldRevision.empty())
+    {
+    this->OldRevision = "0";
+    }

That code comes twice, for the only 2 callers of GetWorkingRevision(). I would 
say just modify that method to return "0" in that case.

Eike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://public.kitware.com/pipermail/cmake-developers/attachments/20131022/84df11a8/attachment.sig>