[cmake-developers] Perforce Patch for CTest
Brad King
brad.king at kitware.com
Tue Oct 22 15:03:41 EDT 2013
On 10/22/2013 02:51 PM, Pedro Navarro wrote:
>> get_filename_component(TOP "${CMAKE_CURRENT_LIST_FILE}" PATH) could be written
>> as CMAKE_CURRENT_LIST_DIR. I don't remember exactly when it was introduced,
>> but you drive that test with the newly built CMake so this must work. And a
>> newline is missing at the end of that file.
>
> Would that be preferred? I have no issues using it but that's what the other
> tests were using, so I wanted them to be as similar as possible.
Yes. The other tests' code predates CMAKE_CURRENT_LIST_DIR.
I would accept the patch for the new test either way though.
Thanks,
-Brad
More information about the cmake-developers
mailing list