[cmake-developers] link-language-static-lib topic

Brad King brad.king at kitware.com
Fri Jul 26 09:43:00 EDT 2013


Steve,

In these hunks:

-  if(this->GetType() == cmTarget::STATIC_LIBRARY)
+  if(this->LinkLanguageDependsOnLinkImplementation())
...
+  bool LinkLanguageDependsOnLinkImplementation() const
+  { return this->TargetTypeValue == STATIC_LIBRARY; }

The description of the test as "link language depends
on link implementation" is not correct.  The blocks
guarded by this test are about setting the interface
link languages of a static library to propagate to
dependents, not the link language of the target itself.
Perhaps

  bool LinkLanguagePropagatesToDependents() const
  { return this->TargetTypeValue == STATIC_LIBRARY; }

or

  bool LinkLanguageInInterface() const
  { return this->TargetTypeValue == STATIC_LIBRARY; }

is better?  Other ideas for a better name?

Thanks,
-Brad



More information about the cmake-developers mailing list