[cmake-developers] Rename Ninja generator?

Peter Collingbourne peter at pcc.me.uk
Thu Mar 8 21:38:35 EST 2012


On Thu, Mar 08, 2012 at 09:25:37PM -0500, Bill Hoffman wrote:
> On 3/8/2012 8:37 PM, Alan W. Irwin wrote:
>>
>> I think that would be confusing to users.
>>
>> Could you define an internal variable (to identify those generators
>> that have Makefile-like characteristics) that could be tested instead
>> of CMAKE_GENERATOR?
>
> I suppose you could, but it would not be backwards compatible. My  
> concern is all the projects that already exist that have code like this:
> if(CMAKE_GENERATOR MATCHES "Makefiles")
>
> A google search of that string gives my 5600 hits...
>
> Just trying to make as many projects work with ninja out of the box as  
> possible.

I did an exact search for that string:

http://www.google.co.uk/search?sourceid=chrome&ie=UTF-8&q=%22if(CMAKE_GENERATOR+MATCHES+Makefiles%22

and received only 36 hits, most of which seem to be matching
CMake's own code, which we can certainly change if necessary.

Thanks,
-- 
Peter


More information about the cmake-developers mailing list