[cmake-developers] find_package error wording

Brad King brad.king at kitware.com
Fri Feb 17 14:20:50 EST 2012


On 2/17/2012 2:16 PM, Alexander Neundorf wrote:
> On Friday 17 February 2012, Brad King wrote:
>> On 2/17/2012 2:01 PM, Alexander Neundorf wrote:
>>> Do you want me to add the new keywords ?
>>> NO_MODULE == CONFIG_MODE == !MODULE == !NO_CONFIG_MODE
>>
>> Yes, but I don't think NO_CONFIG_MODE is necessary.  NO_MODULE
>> will become historical.  Let's make the new ones consistent with
>> each other:
>>
>>     CONFIG_MODE
>>     MODULE_MODE
>>
>> The names have clear mapping to the documented modes.
>>
>> This change can be made first with documentation and tests.
>> I'd like to review and accept that change first.
>
> I'd like to do this on top of the FindPackage_ImprovedErrorMessages branch,
> which has IMO only uncontroversial fixes to the error messages and a small
> bugfix.
> Ok ?
> (since I merged this already into next, and I have never undone such a merge
> yet)

Okay.  The messages will be tweaked again by the new modes though.

-Brad



More information about the cmake-developers mailing list