[cmake-developers] Improving CPack Documentation (and may be others as well)

[David Cole]

On Wed, Feb 1, 2012 at 3:17 PM, Eric Noulard <eric.noulard at gmail.com> wrote:
> 2012/2/1 Eric Noulard <eric.noulard at gmail.com>:
>> 2012/2/1 David Cole <david.cole at kitware.com>:
>>> On Wed, Feb 1, 2012 at 2:27 AM, Rolf Eike Beer <eike at sf-mail.de> wrote:
>>>> Am Dienstag, 31. Januar 2012, 23:39:30 schrieb Eric Noulard:
>>>>> 2012/1/31 Rolf Eike Beer <eike at sf-mail.de>:
>>>>> > Eric Noulard wrote:
>>>>> >> 2012/1/31 Rolf Eike Beer <eike at sf-mail.de>:
>>>>> >> >> Should be fixed and pushed.
>>>>> >> >>
>>>>> >> >> Merge topic 'ImproveCPackDoc-reloaded' into next
>>>>> >> >>
>>>>> >> >> cc4ac32 Calm down compiler warning about unused var
>>>>> >> >> 1b31c19 Fix potential bad memory access, thanks to Rolf
>>>>> >> >
>>>>> >> >                                                     ^^^^
>>>>> >> >
>>>>> >> > You should go and fix this or I will be angry with you for ages. ;)
>>>>> >>
>>>>> >> Is my approximate English wording giving me trouble again
>>>>> >> or are you just kidding?
>>>>> >>
>>>>> >> What's wrong with the comment?
>>>>> >
>>>>> > My name ;)
>>>>> >
>>>>> > -->> Eike <<--
>>>>>
>>>>> ok right sorry about that, won't happen again.
>>>>
>>>> Don't get me wrong: I wont bite because of that. And I tend to ignore if
>>>> people always get it wrong in mails. I just don't want to see it wrong in
>>>> changelogs ;)
>>>>
>>>> Eike
>>>> --
>>>>
>>>> Powered by www.kitware.com
>>>>
>>>> Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html
>>>>
>>>> Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ
>>>>
>>>> Follow this link to subscribe/unsubscribe:
>>>> http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
>>>
>>>
>>> So it looks like Eike made the commit-log-only change to correct the
>>> spelling, re-writing the commit, and pushed the branch to stage again,
>>> but did NOT merge it to 'next'.
>>
>> Yes right I've just seen that while trying to fix dashboard warnings.
>>
>>
>>> Eric, please re-fetch from the stage, continue the topic development
>>> to clean up the dashboard warnings (configure and build) and then push
>>> it back to stage and merge to 'next' again when it's ready.
>>
>> Should be done now.
>>
>>> Some examples of dashboard issues that are due to this branch:
>>>
>>>  http://cdash.org/CDash/viewBuildError.php?type=1&buildid=1966772
>>>  http://cdash.org/CDash/viewConfigure.php?buildid=1966511
>>>  http://cdash.org/CDash/viewBuildError.php?type=1&buildid=1966456
>>
>> Those ones should be fixed.
>> I did not fix all these at once so multiple commit may need squashing.
>>
>> Bill point me to this one:
>> http://www.cdash.org/CDash/viewBuildError.php?buildid=1966258
>> but I don't thinks it come from this branch?
>>
>> Moreover I cannot anything on the reported lines?
>> LEN : Line length exceed 81 (max=79) [Line Length = 79 max chars] (2207)
>> LEN : Line length exceed 80 (max=79) [Line Length = 79 max chars] (2224)
>>
>> nor  in the commit changes;
>> http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=1629615a10df10296ba6588f66a680eed424f9ba#patch12
>>
> Did break it again.
> Sorry I should really avoid working in a hurry.
>
> fixing it.
>
>
> --
> Erk
> Membre de l'April - « promouvoir et défendre le logiciel libre » -
> http://www.april.org


There's no rush here. We won't be reviewing your changes again until
next Tuesday at this point...