[cmake-developers] [CMake 0013129]: [patch] DeployQt4: wrong arguments to install_qt4_plugin

[Mantis Bug Tracker]

The following issue has been SUBMITTED. 
====================================================================== 
http://www.cmake.org/Bug/view.php?id=13129 
====================================================================== 
Reported By:                Daniel Franke
Assigned To:                
====================================================================== 
Project:                    CMake
Issue ID:                   13129
Category:                   Modules
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     new
====================================================================== 
Date Submitted:             2012-04-13 16:04 EDT
Last Modified:              2012-04-13 16:04 EDT
====================================================================== 
Summary:                    [patch] DeployQt4: wrong arguments to
install_qt4_plugin
Description: 
The function DeployQt4.cmake(install_qt4_plugin) has this signature:
  function(install_qt4_plugin plugin executable copy installed_plugin_path_var)

but at line 144 of DeployQt4.cmake it is used as:
  install_qt4_plugin("${plugin}" "${plugins_dir}" "${executable}" 1
installed_plugin_path)

This leads to strange results on Windows (a directory 'installed_plugin_path' is
created instead of ${plugins_dir}).

This trivial patch fixes my immediate problem, didn't test for side effects on
other platforms:

Index: DeployQt4.cmake
===================================================================
--- DeployQt4.cmake	(revision 275)
+++ DeployQt4.cmake	(working copy)
@@ -141,7 +141,7 @@
 
         foreach(plugin ${qtplugins})
                 set(installed_plugin_path "")
-                install_qt4_plugin("${plugin}" "${plugins_dir}" "${executable}"
1 installed_plugin_path)
+                install_qt4_plugin("${plugin}" "${executable}" 1
installed_plugin_path "${plugins_dir}")
                 list(APPEND libs ${installed_plugin_path})
         endforeach()
 
====================================================================== 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2012-04-13 16:04 Daniel Franke  New Issue                                    
======================================================================