[cmake-developers] Ninja: Regressions re. def file handling with MSVC

[Amine Khaldi]

> Thanks.  I've extended the ModuleDefinition test to cover that:
>
> http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=89987c21
>
> and fixed the Ninja generator:
>
> http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=d2c764ad
>
> Ironically commit a2514f15 would have been a smaller patch had
> I used the approach in commit d2c764ad in the first place ;)
>
> Thanks for the detailed report and bisect work. 

You're quite welcome, thank you for fixing this issue promptly :)

> BTW, you should still avoid marking .def files as EXTERNAL_OBJECT.
> Do you know why that mark was added in the first place? 
Committed in r56321, thanks.

This got added at first into the import lib rule here: 
http://git.reactos.org/?p=reactos.git;a=blob;f=reactos/cmake/gcc.cmake;h=31d71b28c9e5156caf75efc2d45b16a23bb503d9;hb=HEAD#l254 
which seems to indicate the "object" needed for the IMPLIB static 
library (this is a custom linker language, used here for our 
convenience). Removing it in this case will lead to some errors.

BTW, please feel free to examine our scripts, we gladly accept any 
feedback. I like how they revealed a missing testcase today for example ;)

Regards,
Amine.