[cmake-developers] Small patch to support build-setting conditions in XCode

[Johan Björk]

How about this one.

/Johan

On Tue, Apr 5, 2011 at 3:35 PM, Johan Björk <phb at spotify.com> wrote:

> yep, but will need to update the code to print the attribute name using
> PrintString(). Will send updated patch.
>
>
> On Tue, Apr 5, 2011 at 3:23 PM, Brad King <brad.king at kitware.com> wrote:
>
>> On 04/05/2011 09:17 AM, Johan Björk wrote:
>> > Tiny patch attached to support build-setting conditions in XCode
>> > (XCODE_ATTRIBUTE_...[sdk=iphone]) for example. The issue was simply that
>> > XCode requires the key to be quoted when it contains [].
>>
>> I think the right place for this is in cmXCodeObject::PrintString where
>> it already checks for characters that need quoting.  Does that work?
>>
>> -Brad
>>
>>
>
>
> --
> Johan Björk
> Team Lead, Development Tools
> Spotify AB
> Address: Birger Jarlsgatan 6, 114 46 Stockholm, Sweden
> Phone:+46 (0)709 22 59 02
>
> This e-mail (including any attachments) may contain information that is
> confidential and/or privileged. It is intended only for the recipient(s).
> If you have reason to believe that you are not the intended recipient of
> this e-mail, please contact the sender immediately and delete the e-mail
> from your computer.
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/cmake-developers/attachments/20110405/fd3b50da/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-XCode-Also-qoute-as-needed-to-set-build-configuratio.patch
Type: application/octet-stream
Size: 3970 bytes
Desc: not available
URL: <http://public.kitware.com/pipermail/cmake-developers/attachments/20110405/fd3b50da/attachment-0002.obj>