[cmake-developers] Pushing to next and closing bugs?

[David Cole]

We don't really have a well-defined procedure that everybody follows w.r.t.
resolving/closing bugs in the bug database.

I typically just add a note when I push a change to 'next', saying that it
is in next, and then go back to resolve the bug when it is merged to master.

For example, see this one:
http://public.kitware.com/Bug/view.php?id=10258

It is probably a good idea (although I didn't do it in the above example) to
mention the git commit hash in your bug tracker note when claiming that
something is fixed. That way, somebody investigating later can look at that
commit and see whether it made it into master, or a given CMake release...

Personally, I don't like the idea of the bug fixer "closing" the bug.
Marking it as "resolved" is entirely appropriate for the fixer of a bug...
but it should be verified as fixed by the person who reported it, who should
then mark the bug as closed.

You start to get into conflict of interest territory when the person fixing
the bug also has responsibility for declaring it "case closed." And I
realize that with an open source project, and shared community effort,
"responsibility" is a vague notion anyhow. But it would be good to develop
some guidelines for the bug tracker that we all as a community agree to
follow....

Maybe some more discussion here is warranted before we decide exactly what
to put on the wiki.

Does this answer your question at all...? :-)


David C.


On Sun, Jul 4, 2010 at 4:09 PM, Eric Noulard <eric.noulard at gmail.com> wrote:

> Hi there,
>
> I did push some bug fixes to next today since the changes
> correspond to bug fixes I did close the corresponding as I was doing that
> before when using CVS.
>
> Now I wonder, when shall I close a bug?
>
>  1) when the fix is pushed to next?
>    or
>  2) when I'm sure the fix reached master?
>
> I did go for 1) before I realize that some fix may not reach master...
>
> whatever the answer is may be it could be added as a note in
> http://www.cmake.org/Wiki/CMake/Git#Publishing
>
> --
> Erk
> Membre de l'April - « promouvoir et défendre le logiciel libre » -
> http://www.april.org
> _______________________________________________
> cmake-developers mailing list
> cmake-developers at cmake.org
> http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/cmake-developers/attachments/20100705/0ce190ee/attachment.html>