[cmake-developers] module merge mania

[Alexander Neundorf]

On Tuesday 19 September 2006 20:09, Brad King wrote:
> Alexander Neundorf wrote:
> > On Tuesday 19 September 2006 18:49, Alexander Neundorf wrote:
> >> On Tuesday 19 September 2006 00:03, Alexander Neundorf wrote:
> >> ...
> >>
> >>> These two macros (check_struct_member and check_pointer_member) also
> >>> both use CHECK_CXX_SOURCE_COMPILES(), i.e. C++.
> >>> Is this a problem ?
> >>>
> >>> I could rename them a bit:
> >>> CHECK_CXX_SOURCE_COMPILES:
> >>> check_class_member()
> >>> check_class_pointer_member()
> >>>
> >>> and two new ones with CHECK_C_SOURCE_COMPILES:
> >>> check_struct_member()
> >>> check_struct_pointer_member()
> >>>
> >>> Better ?
> >>
> >> Any comments ?
> >
> > I could also build the macro so that you can give the language as
> > parameter: check_struct_member(CXX stat st_time STAT_HAS_ST_TIME)
>
> I like the parameter version since "struct" is valid in both C and C++.
>  Please make it give an error if the argument is not "C" or "CXX".

Yes, but this would be the only macro with such a parameter...
I could also simply have two versions:

check_c_struct_member()
check_c_struct_pointer_member()
check_cxx_struct_member()
check_cxx_struct_pointer_member()

Bye
Alex
-- 
Work: alexander.neundorf AT jenoptik.com - http://www.jenoptik-los.de
Home: neundorf AT kde.org                - http://www.kde.org
      alex AT neundorf.net               - http://www.neundorf.net