[cmake-developers] [PATCH] if(FILE_IS_NEWER file1 file2) ->=?iso-8859-1?q?=09if?=(file1 FILE_IS_NEWER file2)

[Alexander Neundorf]

On Monday 23 October 2006 19:38, you wrote:
> Alexander Neundorf wrote:
> > Hi,
> >
> > the attached patch changes the syntax for if(FILE_IS_NEWER)
> > from
> > if(FILE_IS_NEWER file1 file2)
> > to
> > if(file1 FILE_IS_NEWER file2)
> > which is much more natural and in line with the other if-options which
> > take two arguments. Since this hasn't been in any release yet, this
> > should still go in 2.4.4
>
> While it hasn't been in a release it's been there for quite a while and
> I've already suggested it to other users.  Based on your patch I've
> added the syntax
>
> IF(file1 IS_NEWER_THAN file2)

If you ask me, I would remove the old syntax. It hasn't been in any release, 
not even in a beta release, and if it stays, there will be _forever_ users 
asking "why does FILE_IS_NEWER" use this strange syntax, compared to the 
other IF options, and why is it available in two flavours ?".
(I know I'm the one who wrote the patch so I'm actually blaming myself).
I mean there was also the change for the LIST() syntax from 2.4.2beta to 
2.4.3. Users who are running cmake cvs should be able to live with the fact 
that some things might still change IMO.

Bye
Alex
-- 
Work: alexander.neundorf AT jenoptik.com - http://www.jenoptik-los.de
Home: neundorf AT kde.org                - http://www.kde.org
      alex AT neundorf.net               - http://www.neundorf.net