[PATCH] Re: [cmake-developers] splitting the man page ?

Brad King brad.king at kitware.com
Thu Aug 31 13:23:20 EDT 2006


Alexander Neundorf wrote:
> Ok, I added a virtual bool IsDiscouraged() to cmCommand (as a non-native 
> speaker the difference between obsolete and deprecated isn't quite clear to 
> me). So these commands are now only "discouraged". This term is used through 
> the whole patch, the new man pages are also called "cmake-modules" and 
> "cmake-discouraged". Maybe "cmake-compat" or "cmake-deprecated" would be 
> better.

I like the name IsDiscouraged in the source, but I don't think it is the
best name for the man page.  I don't think having the string
"cmake-discouraged" floating around the web is a good idea :)

Please change the name of the generated files to cmake-compat.

> The patch is not perfect, it probably needs some tuning, e.g. for the see-also 
> section or the description at the top of each man page.

I've applied the part of the patch that adds IsDiscouraged to the
cmCommand interface and all the discouraged commands.  This part is not
likely to change:

/cvsroot/CMake/CMake/Source/cmBuildNameCommand.h,v  <--
cmBuildNameCommand.h
new revision: 1.13; previous revision: 1.12
/cvsroot/CMake/CMake/Source/cmCommand.h,v  <--  cmCommand.h
new revision: 1.24; previous revision: 1.23
/cvsroot/CMake/CMake/Source/cmExecProgramCommand.h,v  <--
cmExecProgramCommand.h
new revision: 1.18; previous revision: 1.17
/cvsroot/CMake/CMake/Source/cmInstallFilesCommand.h,v  <--
cmInstallFilesCommand.h
new revision: 1.17; previous revision: 1.16
/cvsroot/CMake/CMake/Source/cmInstallProgramsCommand.h,v  <--
cmInstallProgramsCommand.h
new revision: 1.15; previous revision: 1.14
/cvsroot/CMake/CMake/Source/cmInstallTargetsCommand.h,v  <--
cmInstallTargetsCommand.h
new revision: 1.12; previous revision: 1.11
/cvsroot/CMake/CMake/Source/cmLinkLibrariesCommand.h,v  <--
cmLinkLibrariesCommand.h
new revision: 1.16; previous revision: 1.15
/cvsroot/CMake/CMake/Source/cmMakeDirectoryCommand.h,v  <--
cmMakeDirectoryCommand.h
new revision: 1.9; previous revision: 1.8
/cvsroot/CMake/CMake/Source/cmRemoveCommand.h,v  <--  cmRemoveCommand.h
new revision: 1.7; previous revision: 1.6
/cvsroot/CMake/CMake/Source/cmSubdirCommand.h,v  <--  cmSubdirCommand.h
new revision: 1.16; previous revision: 1.15
/cvsroot/CMake/CMake/Source/cmSubdirDependsCommand.h,v  <--
cmSubdirDependsCommand.h
new revision: 1.8; previous revision: 1.7
/cvsroot/CMake/CMake/Source/cmVTKMakeInstantiatorCommand.h,v  <--
cmVTKMakeInstantiatorCommand.h
new revision: 1.11; previous revision: 1.10
/cvsroot/CMake/CMake/Source/cmVTKWrapJavaCommand.h,v  <--
cmVTKWrapJavaCommand.h
new revision: 1.12; previous revision: 1.11
/cvsroot/CMake/CMake/Source/cmVTKWrapPythonCommand.h,v  <--
cmVTKWrapPythonCommand.h
new revision: 1.12; previous revision: 1.11
/cvsroot/CMake/CMake/Source/cmVTKWrapTclCommand.h,v  <--
cmVTKWrapTclCommand.h
new revision: 1.13; previous revision: 1.12

-Brad



More information about the cmake-developers mailing list