[Cmake-commits] CMake branch, next, updated. v2.8.11.2-4237-g6a49ff2

Alexander Neundorf neundorf at kde.org
Wed Sep 18 18:57:37 EDT 2013


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "CMake".

The branch, next has been updated
       via  6a49ff20d75c51cc03cf7ee63481f3103cd9ebfc (commit)
       via  5f11b8de28227223cdcc8cbdec2ec231a34ebe05 (commit)
       via  2b63734b7f078281540adaaf75b5a25ed897106d (commit)
       via  1ff8c21734b2ea0e56d710d3d199529f76420a38 (commit)
       via  9bcf6adc388c2306033c65270357eb1a1da83d76 (commit)
      from  60991593fec030a7cce4ed976e71e20157cdaebd (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=6a49ff20d75c51cc03cf7ee63481f3103cd9ebfc
commit 6a49ff20d75c51cc03cf7ee63481f3103cd9ebfc
Merge: 6099159 5f11b8d
Author:     Alexander Neundorf <neundorf at kde.org>
AuthorDate: Wed Sep 18 18:57:33 2013 -0400
Commit:     CMake Topic Stage <kwrobot at kitware.com>
CommitDate: Wed Sep 18 18:57:33 2013 -0400

    Merge topic 'EclipseFixWarningMessage' into next
    
    5f11b8d Eclipse: add version 4.3 for completeness
    2b63734 Eclipse: print different message if CMAKE_ECLIPSE_VERSION is already set
    1ff8c21 CMakeFindEclipse: use lowercase for macro calls
    9bcf6ad CMake Nightly Date Stamp


http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=5f11b8de28227223cdcc8cbdec2ec231a34ebe05
commit 5f11b8de28227223cdcc8cbdec2ec231a34ebe05
Author:     Alex Neundorf <neundorf at kde.org>
AuthorDate: Thu Sep 19 00:58:25 2013 +0200
Commit:     Alex Neundorf <neundorf at kde.org>
CommitDate: Thu Sep 19 00:58:25 2013 +0200

    Eclipse: add version 4.3 for completeness
    
    This just adds the version number, there are no features
    depending on this.
    
    Alex

diff --git a/Modules/CMakeFindEclipseCDT4.cmake b/Modules/CMakeFindEclipseCDT4.cmake
index 9453b71..b67e0f0 100644
--- a/Modules/CMakeFindEclipseCDT4.cmake
+++ b/Modules/CMakeFindEclipseCDT4.cmake
@@ -29,6 +29,7 @@ function(_FIND_ECLIPSE_VERSION)
   set(_ECLIPSE_VERSION_NAME_3.6 "Helios" )
   set(_ECLIPSE_VERSION_NAME_3.7 "Indigo" )
   set(_ECLIPSE_VERSION_NAME_4.2 "Juno" )
+  set(_ECLIPSE_VERSION_NAME_4.3 "Kepler" )
 
   if(NOT DEFINED CMAKE_ECLIPSE_VERSION)
     if(CMAKE_ECLIPSE_EXECUTABLE)
@@ -63,6 +64,7 @@ function(_FIND_ECLIPSE_VERSION)
                                                             "3.6 (${_ECLIPSE_VERSION_NAME_3.6})"
                                                             "3.7 (${_ECLIPSE_VERSION_NAME_3.7})"
                                                             "4.2 (${_ECLIPSE_VERSION_NAME_4.2})"
+                                                            "4.3 (${_ECLIPSE_VERSION_NAME_4.3})"
               )
 endfunction()
 

http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=2b63734b7f078281540adaaf75b5a25ed897106d
commit 2b63734b7f078281540adaaf75b5a25ed897106d
Author:     Alex Neundorf <neundorf at kde.org>
AuthorDate: Thu Sep 19 00:53:38 2013 +0200
Commit:     Alex Neundorf <neundorf at kde.org>
CommitDate: Thu Sep 19 00:53:38 2013 +0200

    Eclipse: print different message if CMAKE_ECLIPSE_VERSION is already set
    
    This fixes #14422.
    
    Alex

diff --git a/Modules/CMakeFindEclipseCDT4.cmake b/Modules/CMakeFindEclipseCDT4.cmake
index 2024d04..9453b71 100644
--- a/Modules/CMakeFindEclipseCDT4.cmake
+++ b/Modules/CMakeFindEclipseCDT4.cmake
@@ -19,18 +19,6 @@ find_program(CMAKE_ECLIPSE_EXECUTABLE NAMES eclipse DOC "The Eclipse executable"
 
 function(_FIND_ECLIPSE_VERSION)
   # This code is in a function so the variables used here have only local scope
-  if(CMAKE_ECLIPSE_EXECUTABLE)
-    # use REALPATH to resolve symlinks (http://public.kitware.com/Bug/view.php?id=13036)
-    get_filename_component(_REALPATH_CMAKE_ECLIPSE_EXECUTABLE "${CMAKE_ECLIPSE_EXECUTABLE}" REALPATH)
-    get_filename_component(_ECLIPSE_DIR "${_REALPATH_CMAKE_ECLIPSE_EXECUTABLE}" PATH)
-    file(GLOB _ECLIPSE_FEATURE_DIR "${_ECLIPSE_DIR}/features/org.eclipse.platform*")
-    if(APPLE AND NOT _ECLIPSE_FEATURE_DIR)
-      file(GLOB _ECLIPSE_FEATURE_DIR "${_ECLIPSE_DIR}/../../../features/org.eclipse.platform*")
-    endif()
-    if("${_ECLIPSE_FEATURE_DIR}" MATCHES ".+org.eclipse.platform_([0-9]+\\.[0-9]+).+")
-      set(_ECLIPSE_VERSION ${CMAKE_MATCH_1})
-    endif()
-  endif()
 
   # Set up a map with the names of the Eclipse releases:
   set(_ECLIPSE_VERSION_NAME_    "Unknown" )
@@ -42,14 +30,32 @@ function(_FIND_ECLIPSE_VERSION)
   set(_ECLIPSE_VERSION_NAME_3.7 "Indigo" )
   set(_ECLIPSE_VERSION_NAME_4.2 "Juno" )
 
-  if(_ECLIPSE_VERSION)
-    message(STATUS "Found Eclipse version ${_ECLIPSE_VERSION} (${_ECLIPSE_VERSION_NAME_${_ECLIPSE_VERSION}})")
+  if(NOT DEFINED CMAKE_ECLIPSE_VERSION)
+    if(CMAKE_ECLIPSE_EXECUTABLE)
+      # use REALPATH to resolve symlinks (http://public.kitware.com/Bug/view.php?id=13036)
+      get_filename_component(_REALPATH_CMAKE_ECLIPSE_EXECUTABLE "${CMAKE_ECLIPSE_EXECUTABLE}" REALPATH)
+      get_filename_component(_ECLIPSE_DIR "${_REALPATH_CMAKE_ECLIPSE_EXECUTABLE}" PATH)
+      file(GLOB _ECLIPSE_FEATURE_DIR "${_ECLIPSE_DIR}/features/org.eclipse.platform*")
+      if(APPLE AND NOT _ECLIPSE_FEATURE_DIR)
+        file(GLOB _ECLIPSE_FEATURE_DIR "${_ECLIPSE_DIR}/../../../features/org.eclipse.platform*")
+      endif()
+      if("${_ECLIPSE_FEATURE_DIR}" MATCHES ".+org.eclipse.platform_([0-9]+\\.[0-9]+).+")
+        set(_ECLIPSE_VERSION ${CMAKE_MATCH_1})
+      endif()
+    endif()
+
+    if(_ECLIPSE_VERSION)
+      message(STATUS "Found Eclipse version ${_ECLIPSE_VERSION} (${_ECLIPSE_VERSION_NAME_${_ECLIPSE_VERSION}})")
+    else()
+      set(_ECLIPSE_VERSION "3.6" )
+      message(STATUS "Could not determine Eclipse version, assuming at least ${_ECLIPSE_VERSION} (${_ECLIPSE_VERSION_NAME_${_ECLIPSE_VERSION}}). Adjust CMAKE_ECLIPSE_VERSION if this is wrong.")
+    endif()
+
+    set(CMAKE_ECLIPSE_VERSION "${_ECLIPSE_VERSION} (${_ECLIPSE_VERSION_NAME_${_ECLIPSE_VERSION}})" CACHE STRING "The version of Eclipse. If Eclipse has not been found, 3.6 (Helios) is assumed.")
   else()
-    set(_ECLIPSE_VERSION "3.6" )
-    message(STATUS "Could not determine Eclipse version, assuming at least ${_ECLIPSE_VERSION} (${_ECLIPSE_VERSION_NAME_${_ECLIPSE_VERSION}}). Adjust CMAKE_ECLIPSE_VERSION if this is wrong.")
+    message(STATUS "Eclipse version is set to ${CMAKE_ECLIPSE_VERSION}. Adjust CMAKE_ECLIPSE_VERSION if this is wrong.")
   endif()
 
-  set(CMAKE_ECLIPSE_VERSION "${_ECLIPSE_VERSION} (${_ECLIPSE_VERSION_NAME_${_ECLIPSE_VERSION}})" CACHE STRING "The version of Eclipse. If Eclipse has not been found, 3.6 (Helios) is assumed.")
   set_property(CACHE CMAKE_ECLIPSE_VERSION PROPERTY STRINGS "3.2 (${_ECLIPSE_VERSION_NAME_3.2})"
                                                             "3.3 (${_ECLIPSE_VERSION_NAME_3.3})"
                                                             "3.4 (${_ECLIPSE_VERSION_NAME_3.4})"

http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=1ff8c21734b2ea0e56d710d3d199529f76420a38
commit 1ff8c21734b2ea0e56d710d3d199529f76420a38
Author:     Alex Neundorf <neundorf at kde.org>
AuthorDate: Thu Sep 19 00:14:13 2013 +0200
Commit:     Alex Neundorf <neundorf at kde.org>
CommitDate: Thu Sep 19 00:14:13 2013 +0200

    CMakeFindEclipse: use lowercase for macro calls
    
    Alex

diff --git a/Modules/CMakeFindEclipseCDT4.cmake b/Modules/CMakeFindEclipseCDT4.cmake
index ae17454..2024d04 100644
--- a/Modules/CMakeFindEclipseCDT4.cmake
+++ b/Modules/CMakeFindEclipseCDT4.cmake
@@ -60,13 +60,13 @@ function(_FIND_ECLIPSE_VERSION)
               )
 endfunction()
 
-_FIND_ECLIPSE_VERSION()
+_find_eclipse_version()
 
 # Try to find out how many CPUs we have and set the -j argument for make accordingly
 set(_CMAKE_ECLIPSE_INITIAL_MAKE_ARGS "")
 
 include(ProcessorCount)
-PROCESSORCOUNT(_CMAKE_ECLIPSE_PROCESSOR_COUNT)
+processorcount(_CMAKE_ECLIPSE_PROCESSOR_COUNT)
 
 # Only set -j if we are under UNIX and if the make-tool used actually has "make" in the name
 # (we may also get here in the future e.g. for ninja)

-----------------------------------------------------------------------

Summary of changes:
 Modules/CMakeFindEclipseCDT4.cmake |   46 +++++++++++++++++++++---------------
 Source/CMakeVersion.cmake          |    2 +-
 2 files changed, 28 insertions(+), 20 deletions(-)


hooks/post-receive
-- 
CMake


More information about the Cmake-commits mailing list