[Cmake-commits] CMake branch, next, updated. v2.8.7-2709-g7339cab

Alexander Neundorf neundorf at kde.org
Sat Feb 18 15:02:20 EST 2012


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "CMake".

The branch, next has been updated
       via  7339cab0d39c5bcdceca220d4397b796a6fbab56 (commit)
       via  54e1f6f5a572e47c5598fd53e3b9eb0a66739def (commit)
      from  704a6b00f36f8bfbafd05c074500d63768a13989 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=7339cab0d39c5bcdceca220d4397b796a6fbab56
commit 7339cab0d39c5bcdceca220d4397b796a6fbab56
Merge: 704a6b0 54e1f6f
Author:     Alexander Neundorf <neundorf at kde.org>
AuthorDate: Sat Feb 18 15:02:15 2012 -0500
Commit:     CMake Topic Stage <kwrobot at kitware.com>
CommitDate: Sat Feb 18 15:02:15 2012 -0500

    Merge topic 'GenerateExportHeader_MinorFix' into next
    
    54e1f6f GenerateExportHeader: use double quotes around _gcc_version


http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=54e1f6f5a572e47c5598fd53e3b9eb0a66739def
commit 54e1f6f5a572e47c5598fd53e3b9eb0a66739def
Author:     Alex Neundorf <neundorf at kde.org>
AuthorDate: Sat Feb 18 20:58:19 2012 +0100
Commit:     Alex Neundorf <neundorf at kde.org>
CommitDate: Sat Feb 18 20:58:19 2012 +0100

    GenerateExportHeader: use double quotes around _gcc_version
    
    The GenerateExportHeaders test was failing on one machine, the version
    could not be determined there, so the _gcc_version was empty,
    so the first argument to if() was empty, so it complained:
    http://open.cdash.org/testDetails.php?test=135623436&build=2016288
    Use double quotes to turn the non-existant first argument into an empty
    string.
    
    Alex

diff --git a/Modules/GenerateExportHeader.cmake b/Modules/GenerateExportHeader.cmake
index 781b6e7..f3f61f6 100644
--- a/Modules/GenerateExportHeader.cmake
+++ b/Modules/GenerateExportHeader.cmake
@@ -173,7 +173,7 @@ macro(_test_compiler_hidden_visibility)
         _gcc_version "${_gcc_version_info}")
     endif()
 
-    if(${_gcc_version} VERSION_LESS "4.2")
+    if("${_gcc_version}" VERSION_LESS "4.2")
       set(GCC_TOO_OLD TRUE)
       message(WARNING "GCC version older than 4.2")
     endif()

-----------------------------------------------------------------------

Summary of changes:
 Modules/GenerateExportHeader.cmake |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)


hooks/post-receive
-- 
CMake


More information about the Cmake-commits mailing list