[Cmake-commits] CMake branch, next, updated. v2.8.4-1810-g9bac8cb

Bill Hoffman bill.hoffman at kitware.com
Wed Jun 22 11:55:34 EDT 2011


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "CMake".

The branch, next has been updated
       via  9bac8cb0359fc1e98464437ecb588100fc9798a6 (commit)
       via  ed0075bdb768f8272c2a9fc48e37bf9897427258 (commit)
       via  38368d52f34086294f4647b97a7111fa2547905a (commit)
       via  8cd66dc0d275208367dd6b5ef266395ef92ed424 (commit)
      from  0d5fcf9e761131432667aa93d1ba42ee3f185585 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=9bac8cb0359fc1e98464437ecb588100fc9798a6
commit 9bac8cb0359fc1e98464437ecb588100fc9798a6
Merge: 0d5fcf9 ed0075b
Author:     Bill Hoffman <bill.hoffman at kitware.com>
AuthorDate: Wed Jun 22 11:55:31 2011 -0400
Commit:     CMake Topic Stage <kwrobot at kitware.com>
CommitDate: Wed Jun 22 11:55:31 2011 -0400

    Merge topic 'use_devenv_forvs2010' into next
    
    ed0075b Use relative paths for custom command inputs.
    38368d5 Revert "With very long file names, VS 2010 was unable to compile files."
    8cd66dc Use devenv instead of msbuild for vs2010.


http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=ed0075bdb768f8272c2a9fc48e37bf9897427258
commit ed0075bdb768f8272c2a9fc48e37bf9897427258
Author:     Bill Hoffman <bill.hoffman at kitware.com>
AuthorDate: Wed Jun 22 11:52:15 2011 -0400
Commit:     Bill Hoffman <bill.hoffman at kitware.com>
CommitDate: Wed Jun 22 11:52:15 2011 -0400

    Use relative paths for custom command inputs.
    
    For source files we use full paths.  This allows for longer directory
    names with VS2010. However, the use of full paths causes the GUI
    to not display the custom commands.

diff --git a/Source/cmVisualStudio10TargetGenerator.cxx b/Source/cmVisualStudio10TargetGenerator.cxx
index d15099a..facb551 100644
--- a/Source/cmVisualStudio10TargetGenerator.cxx
+++ b/Source/cmVisualStudio10TargetGenerator.cxx
@@ -367,10 +367,11 @@ cmVisualStudio10TargetGenerator::WriteCustomRule(cmSourceFile* source,
     static_cast<cmGlobalVisualStudio7Generator *>
     (this->GlobalGenerator)->GetConfigurations(); 
   this->WriteString("<CustomBuild Include=\"", 2);
-  std::string path =
-    cmSystemTools::RelativePath(
-      this->Makefile->GetCurrentOutputDirectory(),
-      sourcePath.c_str());
+  // custom command have to use relative paths or they do not
+  // show up in the GUI
+  std::string path = cmSystemTools::RelativePath(
+    this->Makefile->GetCurrentOutputDirectory(),
+    sourcePath.c_str());
   this->ConvertToWindowsSlash(path);
   (*this->BuildFileStream ) << path << "\">\n";
   for(std::vector<std::string>::iterator i = configs->begin();
@@ -611,9 +612,14 @@ WriteGroupSources(const char* name,
     const char* filter = sourceGroup.GetFullName();
     this->WriteString("<", 2); 
     std::string path = source;
-    path = cmSystemTools::RelativePath(
-      this->Makefile->GetCurrentOutputDirectory(),
-      source.c_str());
+    // custom command sources must use relative paths or they will
+    // not show up in the GUI.
+    if(sf->GetCustomCommand())
+      {
+      path = cmSystemTools::RelativePath(
+        this->Makefile->GetCurrentOutputDirectory(),
+        source.c_str());
+      }
     this->ConvertToWindowsSlash(path);
     (*this->BuildFileStream) << name << " Include=\""
                              << path;
@@ -701,9 +707,8 @@ void cmVisualStudio10TargetGenerator::WriteCLSources()
     bool rc = lang && (strcmp(lang, "RC") == 0);
     bool idl = ext == "idl";
     std::string sourceFile = (*source)->GetFullPath();
-    sourceFile =  cmSystemTools::RelativePath(
-      this->Makefile->GetCurrentOutputDirectory(),
-      sourceFile.c_str());
+    // do not use a relative path here because it means that you
+    // can not use as long a path to the file.
     this->ConvertToWindowsSlash(sourceFile);
     // output the source file
     if(header)

http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=38368d52f34086294f4647b97a7111fa2547905a
commit 38368d52f34086294f4647b97a7111fa2547905a
Author:     Bill Hoffman <bill.hoffman at kitware.com>
AuthorDate: Tue Jun 21 16:00:31 2011 -0400
Commit:     Bill Hoffman <bill.hoffman at kitware.com>
CommitDate: Tue Jun 21 16:00:31 2011 -0400

    Revert "With very long file names, VS 2010 was unable to compile files."
    
    This reverts commit 945f2c2214bc80f513ed08ebe2c8003263a4ee56.

diff --git a/Source/cmVisualStudio10TargetGenerator.cxx b/Source/cmVisualStudio10TargetGenerator.cxx
index 6d2338e..d15099a 100644
--- a/Source/cmVisualStudio10TargetGenerator.cxx
+++ b/Source/cmVisualStudio10TargetGenerator.cxx
@@ -367,7 +367,10 @@ cmVisualStudio10TargetGenerator::WriteCustomRule(cmSourceFile* source,
     static_cast<cmGlobalVisualStudio7Generator *>
     (this->GlobalGenerator)->GetConfigurations(); 
   this->WriteString("<CustomBuild Include=\"", 2);
-  std::string path = sourcePath;
+  std::string path =
+    cmSystemTools::RelativePath(
+      this->Makefile->GetCurrentOutputDirectory(),
+      sourcePath.c_str());
   this->ConvertToWindowsSlash(path);
   (*this->BuildFileStream ) << path << "\">\n";
   for(std::vector<std::string>::iterator i = configs->begin();
@@ -608,6 +611,9 @@ WriteGroupSources(const char* name,
     const char* filter = sourceGroup.GetFullName();
     this->WriteString("<", 2); 
     std::string path = source;
+    path = cmSystemTools::RelativePath(
+      this->Makefile->GetCurrentOutputDirectory(),
+      source.c_str());
     this->ConvertToWindowsSlash(path);
     (*this->BuildFileStream) << name << " Include=\""
                              << path;
@@ -695,6 +701,9 @@ void cmVisualStudio10TargetGenerator::WriteCLSources()
     bool rc = lang && (strcmp(lang, "RC") == 0);
     bool idl = ext == "idl";
     std::string sourceFile = (*source)->GetFullPath();
+    sourceFile =  cmSystemTools::RelativePath(
+      this->Makefile->GetCurrentOutputDirectory(),
+      sourceFile.c_str());
     this->ConvertToWindowsSlash(sourceFile);
     // output the source file
     if(header)

http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=8cd66dc0d275208367dd6b5ef266395ef92ed424
commit 8cd66dc0d275208367dd6b5ef266395ef92ed424
Author:     Bill Hoffman <bill.hoffman at kitware.com>
AuthorDate: Tue Jun 21 15:58:11 2011 -0400
Commit:     Bill Hoffman <bill.hoffman at kitware.com>
CommitDate: Tue Jun 21 15:58:11 2011 -0400

    Use devenv instead of msbuild for vs2010.

diff --git a/Modules/CMakeVS10FindMake.cmake b/Modules/CMakeVS10FindMake.cmake
index af5f3a7..388203c 100644
--- a/Modules/CMakeVS10FindMake.cmake
+++ b/Modules/CMakeVS10FindMake.cmake
@@ -1,6 +1,6 @@
 
 #=============================================================================
-# Copyright 2009 Kitware, Inc.
+# Copyright 2007-2009 Kitware, Inc.
 #
 # Distributed under the OSI-approved BSD License (the "License");
 # see accompanying file Copyright.txt for details.
@@ -12,17 +12,28 @@
 # (To distribute this file outside of CMake, substitute the full
 #  License text for the above reference.)
 
-# We use MSBuild as the build tool for VS 10
+# VCExpress does not support cross compiling, which is necessary for Win CE
+SET( _CMAKE_MAKE_PROGRAM_NAMES devenv)
+IF(NOT CMAKE_CROSSCOMPILING)
+  SET( _CMAKE_MAKE_PROGRAM_NAMES ${_CMAKE_MAKE_PROGRAM_NAMES} VCExpress)
+ENDIF(NOT CMAKE_CROSSCOMPILING)
+
 FIND_PROGRAM(CMAKE_MAKE_PROGRAM
-  NAMES MSBuild
+  NAMES ${_CMAKE_MAKE_PROGRAM_NAMES}
   HINTS
-  [HKEY_LOCAL_MACHINE\\SOFTWARE\\Microsoft\\VisualStudio\\10.0\\Setup\\VS;ProductDir]
-  "$ENV{SYSTEMROOT}/Microsoft.NET/Framework/[HKEY_LOCAL_MACHINE\\SOFTWARE\\Microsoft\\VisualStudio\\10.0;CLR Version]/"
-  "c:/WINDOWS/Microsoft.NET/Framework/[HKEY_LOCAL_MACHINE\\SOFTWARE\\Microsoft\\VisualStudio\\10.0;CLR Version]/"
-  "$ENV{SYSTEMROOT}/Microsoft.NET/Framework/[HKEY_LOCAL_MACHINE\\SOFTWARE\\Microsoft\\VCExpress\\10.0;CLR Version]/"
+  [HKEY_LOCAL_MACHINE\\SOFTWARE\\Microsoft\\VisualStudio\\10.0\\Setup\\VS;EnvironmentDirectory]
+  [HKEY_LOCAL_MACHINE\\SOFTWARE\\Microsoft\\VisualStudio\\10.0\\Setup;Dbghelp_path]
+  "$ENV{ProgramFiles}/Microsoft Visual Studio 10.0/Common7/IDE"
+  "$ENV{ProgramFiles}/Microsoft Visual Studio10.0/Common7/IDE"
+  "$ENV{ProgramFiles}/Microsoft Visual Studio 10/Common7/IDE"
+  "$ENV{ProgramFiles}/Microsoft Visual Studio10/Common7/IDE"
+  "$ENV{ProgramFiles} (x86)/Microsoft Visual Studio 10.0/Common7/IDE"
+  "$ENV{ProgramFiles} (x86)/Microsoft Visual Studio10.0/Common7/IDE"
+  "$ENV{ProgramFiles} (x86)/Microsoft Visual Studio 10/Common7/IDE"
+  "$ENV{ProgramFiles} (x86)/Microsoft Visual Studio10/Common7/IDE"
+  "/Program Files/Microsoft Visual Studio 10.0/Common7/IDE/"
+  "/Program Files/Microsoft Visual Studio 10/Common7/IDE/"
   )
-
 MARK_AS_ADVANCED(CMAKE_MAKE_PROGRAM)
 SET(MSVC10 1)
 SET(MSVC_VERSION 1600)
-

-----------------------------------------------------------------------

Summary of changes:
 Modules/CMakeVS10FindMake.cmake            |   29 +++++++++++++++++++--------
 Source/cmVisualStudio10TargetGenerator.cxx |   16 ++++++++++++++-
 2 files changed, 35 insertions(+), 10 deletions(-)


hooks/post-receive
-- 
CMake


More information about the Cmake-commits mailing list