[Cmake-commits] CMake branch, next, updated. v2.8.3-957-g7fa332d
Brad King
brad.king at kitware.com
Thu Dec 16 15:50:43 EST 2010
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "CMake".
The branch, next has been updated
via 7fa332d752209ffe6ab41e494844096401700496 (commit)
via 26cc29a8e284cbfc04bc30942edeb10ecbf7a158 (commit)
from 5f8ae70b7f21b56f8e5435de993b39348f8dea08 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=7fa332d752209ffe6ab41e494844096401700496
commit 7fa332d752209ffe6ab41e494844096401700496
Merge: 5f8ae70 26cc29a
Author: Brad King <brad.king at kitware.com>
AuthorDate: Thu Dec 16 15:50:38 2010 -0500
Commit: CMake Topic Stage <kwrobot at kitware.com>
CommitDate: Thu Dec 16 15:50:38 2010 -0500
Merge topic 'file-GLOB-use-case-warning' into next
26cc29a Warn in find(GLOB) docs about bad use case (#11617)
http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=26cc29a8e284cbfc04bc30942edeb10ecbf7a158
commit 26cc29a8e284cbfc04bc30942edeb10ecbf7a158
Author: Brad King <brad.king at kitware.com>
AuthorDate: Thu Dec 16 15:49:32 2010 -0500
Commit: Brad King <brad.king at kitware.com>
CommitDate: Thu Dec 16 15:49:32 2010 -0500
Warn in find(GLOB) docs about bad use case (#11617)
The first instinct of a lot of users is to use file(GLOB) to assemble
lists of sources. Add a warning to the help text stating that it should
not be used for this purpose and briefly explain why.
Suggested-By: Ryan Pavlik
diff --git a/Source/cmFileCommand.h b/Source/cmFileCommand.h
index e771092..b11dcde 100644
--- a/Source/cmFileCommand.h
+++ b/Source/cmFileCommand.h
@@ -116,7 +116,12 @@ public:
"expressions and store it into the variable. Globbing expressions "
"are similar to regular expressions, but much simpler. If RELATIVE "
"flag is specified for an expression, the results will be returned "
- "as a relative path to the given path.\n"
+ "as a relative path to the given path. "
+ "(We do not recommend using GLOB to collect a list of source files "
+ "from your source tree. If no CMakeLists.txt file changes when a "
+ "source is added or removed then the generated build system cannot "
+ "know when to ask CMake to regenerate.)"
+ "\n"
"Examples of globbing expressions include:\n"
" *.cxx - match all files with extension cxx\n"
" *.vt? - match all files with extension vta,...,vtz\n"
-----------------------------------------------------------------------
Summary of changes:
Source/cmFileCommand.h | 7 ++++++-
1 files changed, 6 insertions(+), 1 deletions(-)
hooks/post-receive
--
CMake
More information about the Cmake-commits
mailing list