[Cmake-commits] CMake branch, next, updated. v2.8.2-372-g01182d6

Alexander Neundorf neundorf at kde.org
Sat Aug 7 17:25:20 EDT 2010


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "CMake".

The branch, next has been updated
       via  01182d63a9e35e5fad6e21f3128dfd88536c4886 (commit)
       via  b6c61561d6cc646e4503b5e27ddd34944a0d6e11 (commit)
       via  656cd2fad284970107c691053422d9bf362be068 (commit)
       via  126db7b0609e368ea3cdd4509131566efa500e02 (commit)
       via  77d909b559be4c09a037a7a7eabef6fd76d77917 (commit)
       via  19b68b9faec1868fe6856aebda128a7b2fb3d887 (commit)
       via  6bb0b6e91502956fb82362e9805205f2be687de3 (commit)
       via  946493faa8274666cfcef0c5dbc388d9f4717b3c (commit)
       via  cb9d1eaca463f0b11808e1faa1ae9587bda923af (commit)
       via  fd69b3310dc314d0a61e31775f4b6ecf6be2d596 (commit)
       via  7c20f7b244c98b177e0eca13b3617c83d4691a77 (commit)
       via  00893669e5d6b3b3ac501fa14bab0e1b61262bab (commit)
      from  3ee7168e810e1a6c55d350366d110fb622ebb635 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=01182d63a9e35e5fad6e21f3128dfd88536c4886
commit 01182d63a9e35e5fad6e21f3128dfd88536c4886
Merge: 3ee7168 b6c6156
Author:     Alex Neundorf <neundorf at kde.org>
AuthorDate: Sat Aug 7 23:22:53 2010 +0200
Commit:     Alex Neundorf <neundorf at kde.org>
CommitDate: Sat Aug 7 23:22:53 2010 +0200

    Merge branch 'ImprovedVersionCheckingInSomeModules' into next
    
    Conflicts:
    	Modules/FindSubversion.cmake
    
    Fixed conflicts in FindSubversion.cmake
    
    Alex

diff --cc Modules/FindSubversion.cmake
index 687aa19,30220d1..14127ba
--- a/Modules/FindSubversion.cmake
+++ b/Modules/FindSubversion.cmake
@@@ -43,7 -50,16 +48,14 @@@ FIND_PROGRAM(Subversion_SVN_EXECUTABLE 
  MARK_AS_ADVANCED(Subversion_SVN_EXECUTABLE)
  
  IF(Subversion_SVN_EXECUTABLE)
 -  SET(Subversion_SVN_FOUND TRUE)
  
+   EXECUTE_PROCESS(COMMAND ${Subversion_SVN_EXECUTABLE} --version
+     OUTPUT_VARIABLE Subversion_VERSION_SVN
+     OUTPUT_STRIP_TRAILING_WHITESPACE)
+ 
+   STRING(REGEX REPLACE "^(.*\n)?svn, version ([.0-9]+).*"
+     "\\2" Subversion_VERSION_SVN "${Subversion_VERSION_SVN}")
+ 
 -
    MACRO(Subversion_WC_INFO dir prefix)
      # the subversion commands should be executed with the C locale, otherwise
      # the message (which are parsed) may be translated, Alex
@@@ -105,8 -114,7 +110,9 @@@
  ENDIF(Subversion_SVN_EXECUTABLE)
  
  INCLUDE(FindPackageHandleStandardArgs)
- FIND_PACKAGE_HANDLE_STANDARD_ARGS(Subversion DEFAULT_MSG Subversion_SVN_EXECUTABLE)
+ FIND_PACKAGE_HANDLE_STANDARD_ARGS(Subversion REQUIRED_VARS Subversion_SVN_EXECUTABLE
+                                              VERSION_VAR Subversion_VERSION_SVN )
  
 +# for compatibility
  SET(Subversion_FOUND ${SUBVERSION_FOUND})
 +SET(Subversion_SVN_FOUND ${SUBVERSION_FOUND})

http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=b6c61561d6cc646e4503b5e27ddd34944a0d6e11
commit b6c61561d6cc646e4503b5e27ddd34944a0d6e11
Author:     Alex Neundorf <neundorf at kde.org>
AuthorDate: Sat Aug 7 23:18:17 2010 +0200
Commit:     Alex Neundorf <neundorf at kde.org>
CommitDate: Sat Aug 7 23:18:17 2010 +0200

    Use FPHSA() in FindSWIG, including version checking.
    
    Alex

diff --git a/Modules/FindSWIG.cmake b/Modules/FindSWIG.cmake
index 6edcb72..76e44bc 100644
--- a/Modules/FindSWIG.cmake
+++ b/Modules/FindSWIG.cmake
@@ -5,6 +5,9 @@
 #  SWIG_EXECUTABLE - the path to the swig executable
 #  SWIG_VERSION   - the version number of the swig executable
 #
+# The minimum required version of SWIG can be specified using the
+# standard syntax, e.g. FIND_PACKAGE(SWIG 1.1)
+#
 # All information is collected from the SWIG_EXECUTABLE so the
 # version to be found can be changed from the command line by
 # means of setting SWIG_EXECUTABLE
@@ -23,8 +26,6 @@
 # (To distributed this file outside of CMake, substitute the full
 #  License text for the above reference.)
 
-SET(SWIG_FOUND FALSE)
-
 FIND_PROGRAM(SWIG_EXECUTABLE swig)
 
 IF(SWIG_EXECUTABLE)
@@ -45,7 +46,6 @@ IF(SWIG_EXECUTABLE)
     SET(SWIG_DIR SWIG_DIR-NOTFOUND)
     FIND_PATH(SWIG_DIR swig.swg PATHS ${SWIG_swiglib_output})
     IF(SWIG_DIR)
-      SET(SWIG_FOUND 1)
       SET(SWIG_USE_FILE ${CMAKE_ROOT}/Modules/UseSWIG.cmake)
       EXECUTE_PROCESS(COMMAND ${SWIG_EXECUTABLE} -version
         OUTPUT_VARIABLE SWIG_version_output
@@ -62,12 +62,6 @@ IF(SWIG_EXECUTABLE)
   ENDIF(SWIG_swiglib_result)
 ENDIF(SWIG_EXECUTABLE)
 
-IF(NOT SWIG_FOUND)
-  IF(NOT SWIG_FIND_QUIETLY)
-    IF(SWIG_FIND_REQUIRED)
-      MESSAGE(FATAL_ERROR "SWIG was not found. Please specify Swig executable location")
-    ELSE(SWIG_FIND_REQUIRED)
-      MESSAGE(STATUS "SWIG was not found. Please specify Swig executable location")
-    ENDIF(SWIG_FIND_REQUIRED)
-  ENDIF(NOT SWIG_FIND_QUIETLY)
-ENDIF(NOT SWIG_FOUND)
+INCLUDE(FindPackageHandleStandardArgs)
+FIND_PACKAGE_HANDLE_STANDARD_ARGS(SWIG  REQUIRED_VARS SWIG_EXECUTABLE SWIG_DIR
+                                        VERSION_VAR SWIG_VERSION )

http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=656cd2fad284970107c691053422d9bf362be068
commit 656cd2fad284970107c691053422d9bf362be068
Author:     Alex Neundorf <neundorf at kde.org>
AuthorDate: Sat Aug 7 23:09:14 2010 +0200
Commit:     Alex Neundorf <neundorf at kde.org>
CommitDate: Sat Aug 7 23:09:14 2010 +0200

    Improved version checking for FindCUDA using the new mode of FPHSA
    
    Alex

diff --git a/Modules/FindCUDA.cmake b/Modules/FindCUDA.cmake
index 81d082a..d9b9d54 100644
--- a/Modules/FindCUDA.cmake
+++ b/Modules/FindCUDA.cmake
@@ -497,29 +497,6 @@ endif()
 # Always set this convenience variable
 set(CUDA_VERSION_STRING "${CUDA_VERSION}")
 
-# Here we need to determine if the version we found is acceptable.  We will
-# assume that is unless CUDA_FIND_VERSION_EXACT or CUDA_FIND_VERSION is
-# specified.  The presence of either of these options checks the version
-# string and signals if the version is acceptable or not.
-set(_cuda_version_acceptable TRUE)
-#
-if(CUDA_FIND_VERSION_EXACT AND NOT CUDA_VERSION VERSION_EQUAL CUDA_FIND_VERSION)
-  set(_cuda_version_acceptable FALSE)
-endif()
-#
-if(CUDA_FIND_VERSION       AND     CUDA_VERSION VERSION_LESS  CUDA_FIND_VERSION)
-  set(_cuda_version_acceptable FALSE)
-endif()
-#
-if(NOT _cuda_version_acceptable)
-  set(_cuda_error_message "Requested CUDA version ${CUDA_FIND_VERSION}, but found unacceptable version ${CUDA_VERSION}")
-  if(CUDA_FIND_REQUIRED)
-    message("${_cuda_error_message}")
-  elseif(NOT CUDA_FIND_QUIETLY)
-    message("${_cuda_error_message}")
-  endif()
-endif()
-
 # CUDA_TOOLKIT_INCLUDE
 find_path(CUDA_TOOLKIT_INCLUDE
   device_functions.h # Header included in toolkit
@@ -687,12 +664,14 @@ set(CUDA_SDK_ROOT_DIR_INTERNAL "${CUDA_SDK_ROOT_DIR}" CACHE INTERNAL
   "This is the value of the last time CUDA_SDK_ROOT_DIR was set successfully." FORCE)
 
 include(FindPackageHandleStandardArgs)
-find_package_handle_standard_args(CUDA DEFAULT_MSG
-  CUDA_TOOLKIT_ROOT_DIR
-  CUDA_NVCC_EXECUTABLE
-  CUDA_INCLUDE_DIRS
-  CUDA_CUDART_LIBRARY
-  _cuda_version_acceptable
+find_package_handle_standard_args(CUDA
+  REQUIRED_VARS
+    CUDA_TOOLKIT_ROOT_DIR
+    CUDA_NVCC_EXECUTABLE
+    CUDA_INCLUDE_DIRS
+    CUDA_CUDART_LIBRARY
+  VERSION_VAR
+    CUDA_VERSION
   )
 
 

http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=126db7b0609e368ea3cdd4509131566efa500e02
commit 126db7b0609e368ea3cdd4509131566efa500e02
Author:     Alex Neundorf <neundorf at kde.org>
AuthorDate: Sat Aug 7 23:00:31 2010 +0200
Commit:     Alex Neundorf <neundorf at kde.org>
CommitDate: Sat Aug 7 23:00:31 2010 +0200

    Improved version checking for FindSubversion using the new mode of FPHSA()
    
    Alex

diff --git a/Modules/FindSubversion.cmake b/Modules/FindSubversion.cmake
index 58a179d..30220d1 100644
--- a/Modules/FindSubversion.cmake
+++ b/Modules/FindSubversion.cmake
@@ -2,7 +2,12 @@
 # The module defines the following variables:
 #  Subversion_SVN_EXECUTABLE - path to svn command line client
 #  Subversion_VERSION_SVN - version of svn command line client
-#  Subversion_FOUND - true if the command line client was found
+#  SUBVERSION_FOUND - true if the command line client was found
+#  Subversion_FOUND - same as SUBVERSION_FOUND, kept around for compatibility
+#
+# The minimum required version of Subversion can be specified using the
+# standard syntax, e.g. FIND_PACKAGE(Subversion 1.4)
+#
 # If the command line client executable is found the macro
 #  Subversion_WC_INFO(<dir> <var-prefix>)
 # is defined to extract information of a subversion working copy at
@@ -17,12 +22,12 @@
 #  <var-prefix>_WC_INFO - output of command `svn info <dir>'
 # Example usage:
 #  FIND_PACKAGE(Subversion)
-#  IF(Subversion_FOUND)
+#  IF(SUBVERSION_FOUND)
 #    Subversion_WC_INFO(${PROJECT_SOURCE_DIR} Project)
 #    MESSAGE("Current revision is ${Project_WC_REVISION}")
 #    Subversion_WC_LOG(${PROJECT_SOURCE_DIR} Project)
 #    MESSAGE("Last changed log is ${Project_LAST_CHANGED_LOG}")
-#  ENDIF(Subversion_FOUND)
+#  ENDIF(SUBVERSION_FOUND)
 
 #=============================================================================
 # Copyright 2006-2009 Kitware, Inc.
@@ -38,7 +43,6 @@
 # (To distributed this file outside of CMake, substitute the full
 #  License text for the above reference.)
 
-SET(Subversion_FOUND FALSE)
 SET(Subversion_SVN_FOUND FALSE)
 
 FIND_PROGRAM(Subversion_SVN_EXECUTABLE svn
@@ -47,7 +51,14 @@ MARK_AS_ADVANCED(Subversion_SVN_EXECUTABLE)
 
 IF(Subversion_SVN_EXECUTABLE)
   SET(Subversion_SVN_FOUND TRUE)
-  SET(Subversion_FOUND TRUE)
+
+  EXECUTE_PROCESS(COMMAND ${Subversion_SVN_EXECUTABLE} --version
+    OUTPUT_VARIABLE Subversion_VERSION_SVN
+    OUTPUT_STRIP_TRAILING_WHITESPACE)
+
+  STRING(REGEX REPLACE "^(.*\n)?svn, version ([.0-9]+).*"
+    "\\2" Subversion_VERSION_SVN "${Subversion_VERSION_SVN}")
+
 
   MACRO(Subversion_WC_INFO dir prefix)
     # the subversion commands should be executed with the C locale, otherwise
@@ -55,11 +66,6 @@ IF(Subversion_SVN_EXECUTABLE)
     SET(_Subversion_SAVED_LC_ALL "$ENV{LC_ALL}")
     SET(ENV{LC_ALL} C)
 
-    EXECUTE_PROCESS(COMMAND ${Subversion_SVN_EXECUTABLE} --version
-      WORKING_DIRECTORY ${dir}
-      OUTPUT_VARIABLE Subversion_VERSION_SVN
-      OUTPUT_STRIP_TRAILING_WHITESPACE)
-
     EXECUTE_PROCESS(COMMAND ${Subversion_SVN_EXECUTABLE} info ${dir}
       OUTPUT_VARIABLE ${prefix}_WC_INFO
       ERROR_VARIABLE Subversion_svn_info_error
@@ -70,8 +76,6 @@ IF(Subversion_SVN_EXECUTABLE)
       MESSAGE(SEND_ERROR "Command \"${Subversion_SVN_EXECUTABLE} info ${dir}\" failed with output:\n${Subversion_svn_info_error}")
     ELSE(NOT ${Subversion_svn_info_result} EQUAL 0)
 
-      STRING(REGEX REPLACE "^(.*\n)?svn, version ([.0-9]+).*"
-        "\\2" Subversion_VERSION_SVN "${Subversion_VERSION_SVN}")
       STRING(REGEX REPLACE "^(.*\n)?URL: ([^\n]+).*"
         "\\2" ${prefix}_WC_URL "${${prefix}_WC_INFO}")
       STRING(REGEX REPLACE "^(.*\n)?Revision: ([^\n]+).*"
@@ -110,4 +114,7 @@ IF(Subversion_SVN_EXECUTABLE)
 ENDIF(Subversion_SVN_EXECUTABLE)
 
 INCLUDE(FindPackageHandleStandardArgs)
-FIND_PACKAGE_HANDLE_STANDARD_ARGS(Subversion DEFAULT_MSG Subversion_SVN_EXECUTABLE)
+FIND_PACKAGE_HANDLE_STANDARD_ARGS(Subversion REQUIRED_VARS Subversion_SVN_EXECUTABLE
+                                             VERSION_VAR Subversion_VERSION_SVN )
+
+SET(Subversion_FOUND ${SUBVERSION_FOUND})

http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=77d909b559be4c09a037a7a7eabef6fd76d77917
commit 77d909b559be4c09a037a7a7eabef6fd76d77917
Author:     Alex Neundorf <neundorf at kde.org>
AuthorDate: Sat Aug 7 22:30:06 2010 +0200
Commit:     Alex Neundorf <neundorf at kde.org>
CommitDate: Sat Aug 7 22:30:06 2010 +0200

    Fix DETAILS string with version number in FHPSA()
    
    If found, the version which was found should be stored in the DETAILS
    string, but it was dereferenced twice, which was wrong.
    
    Alex

diff --git a/Modules/FindPackageHandleStandardArgs.cmake b/Modules/FindPackageHandleStandardArgs.cmake
index 389697e..8502c04 100644
--- a/Modules/FindPackageHandleStandardArgs.cmake
+++ b/Modules/FindPackageHandleStandardArgs.cmake
@@ -214,7 +214,7 @@ FUNCTION(FIND_PACKAGE_HANDLE_STANDARD_ARGS _NAME _FIRST_ARG _VAR1)
   ENDIF (${_NAME}_FIND_VERSION)
 
   IF(VERSION_OK)
-    SET(DETAILS "${DETAILS}[v${${VERSION}}]")
+    SET(DETAILS "${DETAILS}[v${VERSION}]")
   ELSE(VERSION_OK)
     SET(${_NAME_UPPER}_FOUND FALSE)
   ENDIF(VERSION_OK)

http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=19b68b9faec1868fe6856aebda128a7b2fb3d887
commit 19b68b9faec1868fe6856aebda128a7b2fb3d887
Author:     Alex Neundorf <neundorf at kde.org>
AuthorDate: Sat Aug 7 22:29:08 2010 +0200
Commit:     Alex Neundorf <neundorf at kde.org>
CommitDate: Sat Aug 7 22:29:08 2010 +0200

    Improved version checking for FindJava using the new FPHSA() mode
    
    Alex

diff --git a/Modules/FindJava.cmake b/Modules/FindJava.cmake
index 4cd4389..94522d2 100644
--- a/Modules/FindJava.cmake
+++ b/Modules/FindJava.cmake
@@ -13,6 +13,9 @@
 #  Java_VERSION_TWEAK      = The tweak version of the package found (after '_')
 #  Java_VERSION            = This is set to: $major.$minor.$patch(.$tweak)
 #
+# The minimum required version of Java can be specified using the
+# standard CMake syntax, e.g. FIND_PACKAGE(Java 1.5)
+#
 # NOTE: ${Java_VERSION} and ${Java_VERSION_STRING} are not guaranteed to be
 # identical. For example some java version may return:
 # Java_VERSION_STRING = 1.5.0_17
@@ -83,7 +86,6 @@ FIND_PROGRAM(Java_JAVA_EXECUTABLE
 )
 
 IF(Java_JAVA_EXECUTABLE)
-    set(_java_version_acceptable TRUE)
     EXECUTE_PROCESS(COMMAND ${Java_JAVA_EXECUTABLE} -version
       RESULT_VARIABLE res
       OUTPUT_VARIABLE var
@@ -114,7 +116,6 @@ IF(Java_JAVA_EXECUTABLE)
       ELSE()
         IF(NOT Java_FIND_QUIETLY)
           message(WARNING "regex not supported: ${var}. Please report")
-          set(_java_version_acceptable FALSE)
         ENDIF(NOT Java_FIND_QUIETLY)
       ENDIF()
       STRING( REGEX REPLACE "([0-9]+).*" "\\1" Java_VERSION_MAJOR "${Java_VERSION_STRING}" )
@@ -134,17 +135,6 @@ IF(Java_JAVA_EXECUTABLE)
       ENDIF(NOT Java_FIND_QUIETLY)
     ENDIF()
 
-    # check version if requested:
-    if( Java_FIND_VERSION )
-      if("${Java_VERSION}" VERSION_LESS "${Java_FIND_VERSION}")
-        set(_java_version_acceptable FALSE)
-      endif("${Java_VERSION}" VERSION_LESS "${Java_FIND_VERSION}")
-      if( Java_FIND_VERSION_EXACT )
-        if("${Java_VERSION}" VERSION_GREATER "${Java_FIND_VERSION}")
-          set(_java_version_acceptable FALSE)
-        endif("${Java_VERSION}" VERSION_GREATER "${Java_FIND_VERSION}")
-      endif( Java_FIND_VERSION_EXACT )
-    endif( Java_FIND_VERSION )
 ENDIF(Java_JAVA_EXECUTABLE)
 
 
@@ -165,17 +155,15 @@ if(Java_FIND_COMPONENTS)
   foreach(component ${Java_FIND_COMPONENTS})
     # User just want to execute some Java byte-compiled
     if(component STREQUAL "Runtime")
-      find_package_handle_standard_args(Java DEFAULT_MSG
-        Java_JAVA_EXECUTABLE
-        _java_version_acceptable
-      )
+      find_package_handle_standard_args(Java
+        REQUIRED_VARS Java_JAVA_EXECUTABLE
+        VERSION_VAR Java_VERSION
+        )
     elseif(component STREQUAL "Development")
-      find_package_handle_standard_args(Java DEFAULT_MSG
-        Java_JAVA_EXECUTABLE
-        Java_JAR_EXECUTABLE
-        Java_JAVAC_EXECUTABLE
-        _java_version_acceptable
-      )
+      find_package_handle_standard_args(Java
+        REQUIRED_VARS Java_JAVA_EXECUTABLE Java_JAR_EXECUTABLE Java_JAVAC_EXECUTABLE
+        VERSION_VAR Java_VERSION
+        )
     else()
       message(FATAL_ERROR "Comp: ${component} is not handled")
     endif()
@@ -183,12 +171,10 @@ if(Java_FIND_COMPONENTS)
   endforeach(component)
 else()
   # Check for everything
-  find_package_handle_standard_args(Java DEFAULT_MSG
-    Java_JAVA_EXECUTABLE
-    Java_JAR_EXECUTABLE
-    Java_JAVAC_EXECUTABLE
-    _java_version_acceptable
-  )
+  find_package_handle_standard_args(Java
+    REQUIRED_VARS Java_JAVA_EXECUTABLE Java_JAR_EXECUTABLE Java_JAVAC_EXECUTABLE
+    VERSION_VAR Java_VERSION
+    )
 endif()
 
 

http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=6bb0b6e91502956fb82362e9805205f2be687de3
commit 6bb0b6e91502956fb82362e9805205f2be687de3
Author:     Alex Neundorf <neundorf at kde.org>
AuthorDate: Sat Aug 7 22:08:51 2010 +0200
Commit:     Alex Neundorf <neundorf at kde.org>
CommitDate: Sat Aug 7 22:08:51 2010 +0200

    Improved version checking for FindRuby using the new mode of FPHSA()
    
    Alex

diff --git a/Modules/FindRuby.cmake b/Modules/FindRuby.cmake
index 45e2da6..cbb8574 100644
--- a/Modules/FindRuby.cmake
+++ b/Modules/FindRuby.cmake
@@ -1,7 +1,10 @@
 # - Find Ruby
 # This module finds if Ruby is installed and determines where the include files
-# and libraries are. Ruby 1.8 and 1.9 are supported. The minimum required version 
-# specified in the find_package() command is honored.
+# and libraries are. Ruby 1.8 and 1.9 are supported.
+#
+# The minimum required version of Ruby can be specified using the
+# standard syntax, e.g. FIND_PACKAGE(Ruby 1.8)
+#
 # It also determines what the name of the library is. This
 # code sets the following variables:
 #
@@ -154,22 +157,6 @@ SET(_RUBY_VERSION_SHORT "${RUBY_VERSION_MAJOR}.${RUBY_VERSION_MINOR}")
 SET(_RUBY_VERSION_SHORT_NODOT "${RUBY_VERSION_MAJOR}${RUBY_VERSION_MINOR}")
 SET(_RUBY_NODOT_VERSION "${RUBY_VERSION_MAJOR}${RUBY_VERSION_MINOR}${RUBY_VERSION_PATCH}")
 
-# Now we know which version we found
-IF(Ruby_FIND_VERSION)
-   IF(${RUBY_VERSION}  VERSION_LESS  ${Ruby_FIND_VERSION})
-      # force running ruby the next time again
-      SET(RUBY_VERSION_MAJOR    ""    CACHE PATH "The Ruby major version" FORCE)
-      IF(Ruby_FIND_REQUIRED)
-         MESSAGE(FATAL_ERROR "Ruby version ${Ruby_FIND_VERSION} required, but only version ${RUBY_VERSION} found.")
-      ELSE(Ruby_FIND_REQUIRED)
-         IF(NOT Ruby_FIND_QUIETLY)
-            MESSAGE(STATUS "Ruby version ${Ruby_FIND_VERSION} required, but only version ${RUBY_VERSION} found.")
-         ENDIF(NOT Ruby_FIND_QUIETLY)
-         RETURN()
-      ENDIF(Ruby_FIND_REQUIRED)
-   ENDIF(${RUBY_VERSION}  VERSION_LESS  ${Ruby_FIND_VERSION})
-ENDIF(Ruby_FIND_VERSION)
-
 FIND_PATH(RUBY_INCLUDE_DIR
    NAMES ruby.h
    HINTS
@@ -240,7 +227,8 @@ IF(_RUBY_DEBUG_OUTPUT)
    MESSAGE(STATUS "--------------------")
 ENDIF(_RUBY_DEBUG_OUTPUT)
 
-FIND_PACKAGE_HANDLE_STANDARD_ARGS(Ruby  DEFAULT_MSG  ${_RUBY_REQUIRED_VARS})
+FIND_PACKAGE_HANDLE_STANDARD_ARGS(Ruby  REQUIRED_VARS  ${_RUBY_REQUIRED_VARS}
+                                        VERSION_VAR RUBY_VERSION )
 
 MARK_AS_ADVANCED(
   RUBY_EXECUTABLE

http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=946493faa8274666cfcef0c5dbc388d9f4717b3c
commit 946493faa8274666cfcef0c5dbc388d9f4717b3c
Author:     Alex Neundorf <neundorf at kde.org>
AuthorDate: Sat Aug 7 22:02:57 2010 +0200
Commit:     Alex Neundorf <neundorf at kde.org>
CommitDate: Sat Aug 7 22:02:57 2010 +0200

    FindSquish doesn't detect the version, remove that from the documentation
    
    Alex

diff --git a/Modules/FindSquish.cmake b/Modules/FindSquish.cmake
index 2327186..f16a693 100644
--- a/Modules/FindSquish.cmake
+++ b/Modules/FindSquish.cmake
@@ -4,9 +4,6 @@
 #
 # ---- Variables and Macros
 #  SQUISH_FOUND                    If false, don't try to use Squish
-#  SQUISH_VERSION_MAJOR            The major version of Squish found
-#  SQUISH_VERSION_MINOR            The minor version of Squish found
-#  SQUISH_VERSION_PATCH            The patch version of Squish found
 #
 #  SQUISH_INSTALL_DIR              The Squish installation directory (containing bin, lib, etc)
 #  SQUISH_SERVER_EXECUTABLE        The squishserver executable

http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=cb9d1eaca463f0b11808e1faa1ae9587bda923af
commit cb9d1eaca463f0b11808e1faa1ae9587bda923af
Author:     Alex Neundorf <neundorf at kde.org>
AuthorDate: Sat Aug 7 22:01:44 2010 +0200
Commit:     Alex Neundorf <neundorf at kde.org>
CommitDate: Sat Aug 7 22:01:44 2010 +0200

    Add version checking support to FindFlex and FindPerlLibs
    
    Use the new mode of FPHSA() to add version checking for these two modules.
    
    Alex

diff --git a/Modules/FindFLEX.cmake b/Modules/FindFLEX.cmake
index 068ee75..1f289e0 100644
--- a/Modules/FindFLEX.cmake
+++ b/Modules/FindFLEX.cmake
@@ -6,6 +6,10 @@
 #  FLEX_VERSION - the version of flex
 #  FLEX_LIBRARIES - The flex libraries
 #
+# The minimum required version of flex can be specified using the
+# standard syntax, e.g. FIND_PACKAGE(FLEX 2.5.13)
+#
+#
 # If flex is found on the system, the module provides the macro:
 #  FLEX_TARGET(Name FlexInput FlexOutput [COMPILE_FLAGS <string>])
 # which creates a custom command  to generate the <FlexOutput> file from
@@ -136,6 +140,7 @@ IF(FLEX_EXECUTABLE)
 ENDIF(FLEX_EXECUTABLE)
 
 INCLUDE(FindPackageHandleStandardArgs)
-FIND_PACKAGE_HANDLE_STANDARD_ARGS(FLEX DEFAULT_MSG FLEX_EXECUTABLE)
+FIND_PACKAGE_HANDLE_STANDARD_ARGS(FLEX REQUIRED_VARS FLEX_EXECUTABLE
+                                       VERSION_VAR FLEX_VERSION)
 
 # FindFLEX.cmake ends here
diff --git a/Modules/FindPerlLibs.cmake b/Modules/FindPerlLibs.cmake
index 422282f..13f3910 100644
--- a/Modules/FindPerlLibs.cmake
+++ b/Modules/FindPerlLibs.cmake
@@ -8,6 +8,9 @@
 #  PERL_LIBRARY      = path to libperl
 #  PERL_EXECUTABLE   = full path to the perl binary
 #
+# The minimum required version of Perl can be specified using the
+# standard syntax, e.g. FIND_PACKAGE(PerlLibs 6.0)
+#
 #  The following variables are also available if needed
 #  (introduced after CMake 2.6.4)
 #
@@ -227,8 +230,9 @@ endif (PERL_EXECUTABLE)
 
 # handle the QUIETLY and REQUIRED arguments and set PERLLIBS_FOUND to TRUE if 
 # all listed variables are TRUE
-INCLUDE(FindPackageHandleStandardArgs)
-FIND_PACKAGE_HANDLE_STANDARD_ARGS(PerlLibs DEFAULT_MSG PERL_LIBRARY PERL_INCLUDE_PATH)
+include(FindPackageHandleStandardArgs)
+find_package_handle_standard_args(PerlLibs REQUIRED_VARS PERL_LIBRARY PERL_INCLUDE_PATH
+                                           VERSION_VAR PERL_VERSION)
 
 # Introduced after CMake 2.6.4 to bring module into compliance
 set(PERL_INCLUDE_DIR  ${PERL_INCLUDE_PATH})

-----------------------------------------------------------------------

Summary of changes:
 Modules/FindCUDA.cmake                      |   37 +++++-----------------
 Modules/FindFLEX.cmake                      |    7 ++++-
 Modules/FindJava.cmake                      |   44 +++++++++-----------------
 Modules/FindPackageHandleStandardArgs.cmake |    2 +-
 Modules/FindPerlLibs.cmake                  |    8 ++++-
 Modules/FindRuby.cmake                      |   26 ++++-----------
 Modules/FindSWIG.cmake                      |   18 ++++-------
 Modules/FindSquish.cmake                    |    3 --
 Modules/FindSubversion.cmake                |   28 ++++++++++-------
 Source/kwsys/kwsysDateStamp.cmake           |    2 +-
 10 files changed, 67 insertions(+), 108 deletions(-)


hooks/post-receive
-- 
CMake


More information about the Cmake-commits mailing list