[Cmake-commits] [cmake-commits] lowman committed FindBoost.cmake 1.20 1.21

cmake-commits at cmake.org cmake-commits at cmake.org
Sun Jan 18 15:41:20 EST 2009


Update of /cvsroot/CMake/CMake/Modules
In directory public:/mounts/ram/cvs-serv10900

Modified Files:
	FindBoost.cmake 
Log Message:
BUG: Removed some code which was squashing Boost_LIBRARIES on WIN32 under the auspices of forcing the user to use autolinking, but it only did this squashing on the first call to FindBoost.  Subsequent calls to FindBoost would not have Boost_LIBRARIES squashed so this code was doing nothing.  If you link your target_link_libraries() against dynamic boost libraries it appears from tools like Dependency Walker that the pragma calls to autolink to the static boost libraries are ignored.  It's therefore too late to make this squash apply to all calls to FindBoost because that would break users that have not setup autolinking properly.   For now this fix is largely cosmetic since the original code never worked anyways (see version 1.5 introduced on 4/22/08).


Index: FindBoost.cmake
===================================================================
RCS file: /cvsroot/CMake/CMake/Modules/FindBoost.cmake,v
retrieving revision 1.20
retrieving revision 1.21
diff -C 2 -d -r1.20 -r1.21
*** FindBoost.cmake	18 Jan 2009 20:17:31 -0000	1.20
--- FindBoost.cmake	18 Jan 2009 20:41:18 -0000	1.21
***************
*** 793,803 ****
    ENDIF(Boost_FOUND)
  
-   # Under Windows, automatic linking is performed, so no need to specify the libraries.
-   IF (WIN32)
-     IF (NOT MINGW)
-       SET(Boost_LIBRARIES "")
-     ENDIF (NOT MINGW)
-   ENDIF(WIN32)
- 
    # show the Boost_INCLUDE_DIRS AND Boost_LIBRARIES variables only in the advanced view
    MARK_AS_ADVANCED(Boost_INCLUDE_DIR
--- 793,796 ----



More information about the Cmake-commits mailing list