[Cmake-commits] [cmake-commits] king committed CMakeLists.txt 1.11 1.12

cmake-commits at cmake.org cmake-commits at cmake.org
Fri Apr 24 11:18:14 EDT 2009


Update of /cvsroot/CMake/CMake/Tests/Preprocess
In directory public:/mounts/ram/cvs-serv4815/Tests/Preprocess

Modified Files:
	CMakeLists.txt 
Log Message:
ENH: Support more preprocessor values in VS6

Previously we rejected all preprocessor definition values containing
spaces for the VS6 IDE generator.  In fact VS6 does support spaces but
not in combination with '"', '$', or ';', and only if we use the sytnax
'-DNAME="value with spaces"' instead of '-D"NAME=value with spaces"'.
Now we support all definition values that do not have one of these
invalid pairs.  See issue #8779.


Index: CMakeLists.txt
===================================================================
RCS file: /cvsroot/CMake/CMake/Tests/Preprocess/CMakeLists.txt,v
retrieving revision 1.11
retrieving revision 1.12
diff -C 2 -d -r1.11 -r1.12
*** CMakeLists.txt	23 Mar 2009 18:48:09 -0000	1.11
--- CMakeLists.txt	24 Apr 2009 15:18:06 -0000	1.12
***************
*** 67,72 ****
  
  if(NOT PP_VS6)
!   # VS 6 IDE: spaces
!   # The project parser unconditionally separates arguments at spaces.
    set(STRING_EXTRA "${STRING_EXTRA} ")
  
--- 67,73 ----
  
  if(NOT PP_VS6)
!   # VS 6 IDE: spaces and '"', '$', or ';'
!   # The project parser cannot handle spaces if there are quotes.
!   # Since we test passing in a quoted string, we cannot have spaces.
    set(STRING_EXTRA "${STRING_EXTRA} ")
  



More information about the Cmake-commits mailing list