[Cmake-commits] [cmake-commits] king committed cmCTestBuildAndTestHandler.cxx 1.23 1.24

cmake-commits at cmake.org cmake-commits at cmake.org
Thu Dec 18 12:28:01 EST 2008


Update of /cvsroot/CMake/CMake/Source/CTest
In directory public:/mounts/ram/cvs-serv5724/Source/CTest

Modified Files:
	cmCTestBuildAndTestHandler.cxx 
Log Message:
ENH: Minor readability improvement in CTest output

When ctest --build-and-test runs the --test-command its output did not
quote the arguments of the command being tested making it difficult to
read.  This adds the quotes.  This also changes the wording of the
failure case to not sound like CTest could not run the executable when
in fact it ran and returned failure.


Index: cmCTestBuildAndTestHandler.cxx
===================================================================
RCS file: /cvsroot/CMake/CMake/Source/CTest/cmCTestBuildAndTestHandler.cxx,v
retrieving revision 1.23
retrieving revision 1.24
diff -C 2 -d -r1.23 -r1.24
*** cmCTestBuildAndTestHandler.cxx	26 Nov 2008 19:38:43 -0000	1.23
--- cmCTestBuildAndTestHandler.cxx	18 Dec 2008 17:27:59 -0000	1.24
***************
*** 360,367 ****
      cmSystemTools::ChangeDirectory(this->BuildRunDir.c_str());
      }
!   out << "Running test executable: " << fullPath << " ";
    for(k=0; k < this->TestCommandArgs.size(); ++k)
      {
!     out << this->TestCommandArgs[k] << " ";
      }
    out << "\n";
--- 360,367 ----
      cmSystemTools::ChangeDirectory(this->BuildRunDir.c_str());
      }
!   out << "Running test command: \"" << fullPath << "\"";
    for(k=0; k < this->TestCommandArgs.size(); ++k)
      {
!     out << " \"" << this->TestCommandArgs[k] << "\"";
      }
    out << "\n";
***************
*** 387,391 ****
    if(runTestRes != cmsysProcess_State_Exited || retval != 0)
      {
!     out << "Failed to run test command: " << testCommand[0] << "\n";
      retval = 1;
      }
--- 387,391 ----
    if(runTestRes != cmsysProcess_State_Exited || retval != 0)
      {
!     out << "Test command failed: " << testCommand[0] << "\n";
      retval = 1;
      }



More information about the Cmake-commits mailing list