<div dir="ltr"><div class="gmail_default" style="font-family:trebuchet ms,sans-serif">Yes, that's what I was suggesting. Author would return the P4 username but I was thinking on adding a new "Full Name" field which, if present, will be used in the Daily Changes screen so you would see that the change was commited by "Pedro Navarro" instead of "pnavarro". It would make the mailto links clearer.</div>
<div class="gmail_default" style="font-family:trebuchet ms,sans-serif"><br></div><div class="gmail_default" style="font-family:trebuchet ms,sans-serif">Pedro</div></div><div class="gmail_extra"><br><br><div class="gmail_quote">
On Mon, Nov 11, 2013 at 12:07 PM, Julien Jomier <span dir="ltr"><<a href="mailto:julien.jomier@kitware.com" target="_blank">julien.jomier@kitware.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Hi Pedro,<br>
<br>
Relying on full name could be tricky because of homonyms. Author is supposed to be the username (or sometimes the email address on some VCS). If Perforce requires a username to register then the author field should return usernames. If Perforce requires the email then the author field should return emails.<br>
<br>
Julien<div class="im"><br>
<br>
On 08/11/2013 19:46, Pedro Navarro wrote:<br>
</div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="im">
Hi Julien,<br>
<br>
So this means that CDash is expecting "author" to be the user name<br>
(pnavarro) and not the full name (Pedro Navarro), right? Wouldn't it<br>
make more sense, then, to add a new "Full Name" field that, if not set<br>
by the VCS would be a duplicate of the "author" field? For the daily<br>
updates view (or build update view) the mailto: link would display "full<br>
name" but in other places, especially SQL joins the "author" field would<br>
be used as it is now.<br>
<br>
Pedro<br>
<br>
<br>
On Tue, Nov 5, 2013 at 8:27 AM, Julien Jomier <<a href="mailto:julien.jomier@kitware.com" target="_blank">julien.jomier@kitware.com</a><br></div><div class="im">
<mailto:<a href="mailto:julien.jomier@kitware.com" target="_blank">julien.jomier@kitware.<u></u>com</a>>> wrote:<br>
<br>
Hi Pedro,<br>
<br>
The main issue is that some VCS don't provide the email field.<br>
<br>
I think we should change the SQL request to add a match on the<br>
dailyupdatefile.email with user2repository.credential along with the<br>
usual request we have right now.<br>
<br>
Could you log a bug report and we'll try to address that.<br>
<br>
Thanks,<br>
Julien<br>
<br>
<br>
On 04/11/2013 22:33, Pedro Navarro wrote:<br>
<br>
Hi,<br>
<br>
When CDash gathers the list of updates from Perforce the users are<br>
returned as author="Full Name", email="<a href="mailto:user@company.com" target="_blank">user@company.com</a><br>
<mailto:<a href="mailto:user@company.com" target="_blank">user@company.com</a>><br></div>
<mailto:<a href="mailto:user@company.com" target="_blank">user@company.com</a> <mailto:<a href="mailto:user@company.com" target="_blank">user@company.com</a>>>". The<div class="im"><br>
problem is that on the Manage Users page<br>
<br>
we get lots of messages like:<br>
<br>
"Pedro Navarro is not registerd for this project but has been<br>
submitting<br>
in the past month".<br>
<br>
The issue is that in manageProjectRoles.php page, the sql query<br>
to get<br>
unregistered users has:<br>
<br>
...LEFT JOIN user2repository ON<br></div>
(dailyupdatefile.author=__<u></u>user2repository.credential ...<div class="im"><br>
<br>
It's matching the author of the commit with the repository<br>
credentials!<br>
In this case dailyupdatefile.author="Pedro Navarro" and<br></div>
user2repository.credential="<a href="mailto:pn__avarro@netflix.com" target="_blank">pn<u></u>__avarro@netflix.com</a><br>
<mailto:<a href="mailto:pnavarro@netflix.com" target="_blank">pnavarro@netflix.com</a>><br>
<mailto:<a href="mailto:pnavarro@netflix.com" target="_blank">pnavarro@netflix.com</a> <mailto:<a href="mailto:pnavarro@netflix.com" target="_blank">pnavarro@netflix.com</a>>><u></u>"__.<div class="im">
<br>
If I add "Pedro Navarro" as a repository<br>
<br>
credential everything works fine but this doesn't seem right and<br>
leads<br>
me to the following questions:<br>
<br>
- Is Perforce the only VCS that's returning full user names?<br>
Should we<br>
not do that?<br>
- Wouldn't it be better to match dailyupdatefile.email with<br>
user2repository.credential? After all the user's E-Mail is<br>
always added<br>
as a credential by default.<br>
<br>
Pedro<br>
<br>
<br>
<br>
<br>
<br></div>
______________________________<u></u>___________________<br>
Cdash mailing list<br>
<a href="mailto:Cdash@public.kitware.com" target="_blank">Cdash@public.kitware.com</a> <mailto:<a href="mailto:Cdash@public.kitware.com" target="_blank">Cdash@public.kitware.<u></u>com</a>><br>
<a href="http://public.kitware.com/cgi-__bin/mailman/listinfo/cdash" target="_blank">http://public.kitware.com/cgi-<u></u>__bin/mailman/listinfo/cdash</a><br>
<<a href="http://public.kitware.com/cgi-bin/mailman/listinfo/cdash" target="_blank">http://public.kitware.com/<u></u>cgi-bin/mailman/listinfo/cdash</a><u></u>><br>
<br>
<br>
</blockquote>
</blockquote></div><br></div>