View Issue Details [ Jump to Notes ]

[ Print ]

ID

Project

Category

View Status

Date Submitted

Last Update

0004089

CMake

CMake

public

2006-11-29 08:03

2016-06-10 14:30

Reporter

Joseph

Assigned To

Brad King

Priority

normal

Severity

major

Reproducibility

always

Status

closed

Resolution

moved

Platform

OS

OS Version

Product Version

Target Version

Fixed in Version

Summary

0004089: Visual Studio generator doesn't handle custom optimizations

Description

I am trying to compile one of my targets with the following optimization flags:
"/Og /Oi /Ot /Oy /Ob2 /Gs /GF"
That's equivalent to "/O2 /Gy-", but I can't use /Gy- because it's only supported in VS2005 and because cmake doesn't parse it correctly.
Now it turns out I can't use that long sequence either, because the following happens:
1. As none of /Od, /O1, /O2, /Ox is present, the Optimization=x attribute is not put to a .vcproj file.
2. Visual Studio doesn't default to "Custom" optimization, but rather to "Maximize Speed", which causes /O2 to be used instead of my custom flags.

A patch is attached.

Tags

No tags attached.

Attached Files

cmLocalVisualStudio7Generator.diff [^] (684 bytes) 1969-12-31 19:00 [Show Content] [Hide Content]

--- Source/cmLocalVisualStudio7Generator.cxx	Mon Nov 20 14:46:26 2006
+++ Source/cmLocalVisualStudio7Generator.cxx	Tue Nov 28 20:50:18 2006
@@ -500,6 +500,14 @@
   // this function call
   this->FillFlagMapFromCommandFlags
     (flagMap, &cmLocalVisualStudio7GeneratorFlagTable[0], flags);
+  
+  // if "Optimization" attribute is missing, Visual Studio defaults
+  // to "Maximize Speed" rather than "Custom".
+  if (flagMap.find("Optimization") == flagMap.end())
+    {
+    flagMap["Optimization"] = "4"; // custom optimization
+    }
+	
   std::string defineFlags = this->Makefile->GetDefineFlags();
 
   // now check the define flags for flags other than -D and

Relationships

Notes
(0006516) Bill Hoffman (manager) 2007-02-21 14:03	Will your new flag parsing stuff fix this?

(0006517) Brad King (manager) 2007-02-21 14:18	No, but the same fix is easily ported to my new parser by writing a method similar to that FixExceptionHandlingDefault.

(0030563) Brad King (manager) 2012-08-13 10:44	Sending issues I'm not actively working on to the backlog to await someone with time for them. If an issue you care about is sent to the backlog when you feel it should have been addressed in a different manner, please bring it up on the CMake mailing list for discussion. Sign up for the mailing list here, if you're not already on it: http://www.cmake.org/mailman/listinfo/cmake [^] It's easy to re-activate a bug here if you can find a CMake developer or contributor who has the bandwidth to take it on.

(0041334) Kitware Robot (administrator) 2016-06-10 14:27	Resolving issue as `moved`. This issue tracker is no longer used. Further discussion of this issue may take place in the current CMake Issues page linked in the banner at the top of this page.

Issue History
Date Modified	Username	Field	Change
2012-08-13 10:44	Brad King	Status	assigned => backlog
2012-08-13 10:44	Brad King	Note Added: 0030563
2016-06-10 14:27	Kitware Robot	Note Added: 0041334
2016-06-10 14:27	Kitware Robot	Status	backlog => resolved
2016-06-10 14:27	Kitware Robot	Resolution	open => moved
2016-06-10 14:30	Kitware Robot	Status	resolved => closed

Copyright © 2000 - 2018 MantisBT Team