| View Issue Details [ Jump to Notes ] | [ Print ] | ||||||||
| ID | Project | Category | View Status | Date Submitted | Last Update | ||||
| 0014741 | CMake | Modules | public | 2014-02-06 21:17 | 2014-10-06 10:32 | ||||
| Reporter | nicolasmartin3d | ||||||||
| Assigned To | Stephen Kelly | ||||||||
| Priority | normal | Severity | minor | Reproducibility | always | ||||
| Status | closed | Resolution | no change required | ||||||
| Platform | OS | OsX | OS Version | 10.9.1 | |||||
| Product Version | |||||||||
| Target Version | Fixed in Version | ||||||||
| Summary | 0014741: FindCXXFeatures (in branch next) does not work | ||||||||
| Description | Hi, I know the file is not part of current release, but still I think this is a bug if it the file is included as is. I tested the module FindCXXFeatures.cmake in the branch next, and it did not work. This is because the file skipped over the check for features, and directly failed. Changing : foreach (_cxx_feature IN LISTS CXXFEATURES_FIND_COMPONENTS) to : foreach (_cxx_feature IN LISTS CXXFeatures_FIND_COMPONENTS) did the trick. I would like to add the check for another feature, in particular for std::thread. Should I open another ticket for this ? | ||||||||
| Tags | No tags attached. | ||||||||
| Attached Files | |||||||||
| Relationships | |
| Relationships |
| Notes | |
|
(0035046) Stephen Kelly (developer) 2014-02-07 02:22 |
The approach in that branch is not going to be the approach that eventually gets into master. I have an alternative branch instead with a different approach to the problem https://gitorious.org/cmake/steveires-cmake/commits/target_compile_features [^] The std::thread request should get a new bug report, particularly as it is not a compile feature but a std lib feature. |
|
(0036905) Robert Maynard (manager) 2014-10-06 10:32 |
Closing resolved issues that have not been updated in more than 4 months. |
| Notes |
| Issue History | |||
| Date Modified | Username | Field | Change |
| 2014-02-06 21:17 | nicolasmartin3d | New Issue | |
| 2014-02-07 02:22 | Stephen Kelly | Note Added: 0035046 | |
| 2014-02-07 02:22 | Stephen Kelly | Status | new => resolved |
| 2014-02-07 02:22 | Stephen Kelly | Resolution | open => no change required |
| 2014-02-07 02:22 | Stephen Kelly | Assigned To | => Stephen Kelly |
| 2014-10-06 10:32 | Robert Maynard | Note Added: 0036905 | |
| 2014-10-06 10:32 | Robert Maynard | Status | resolved => closed |
| Issue History |
| Copyright © 2000 - 2018 MantisBT Team |