View Issue Details Jump to Notes ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0010902CMakeCMakepublic2010-06-28 10:192010-09-10 00:06
ReporterDavid Genest 
Assigned ToBrad King 
PrioritynormalSeverityblockReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product VersionCMake-2-8 
Target VersionCMake 2.8.3Fixed in VersionCMake 2.8.3 
Summary0010902: USER_MAKE_RULES_OVERRIDE variable is not used in initial try_compile
DescriptionI am modifying the toolchain used to create a build on PlayStation 3 using the USER_MAKE_RULES_OVERRIDE variable. This variable is not taken into account in the try_compile that cmake generates and runs to verify the toolchain. Cmake fails on linking because some windows specific link commands get added to the build. (PS3 builds are made through an integration with visual studio so some parts get detected as a windows-cl platform which it is not.)

The attached patch also contains a fix for generating valid build files on ps3: the comma separator between defines is not supported in a ps3 build, and by experimentation, the semicolon fixes it and is also supported by visual studio 9 2008 and by memory it works also on 2005.
Additional InformationThe patch is against 2.8.0, but I checked the gitweb repo and the related files have not changed in 2.8.1
TagsNo tags attached.
Attached Filespatch file icon cmake_uses_USER_MAKE_RULES_OVERRIDE_in_try_compile.patch [^] (1,561 bytes) 2010-06-28 10:19 [Show Content]

 Relationships
related to 0011469closedBrad King CMAKE_USER_MAKE_RULES_OVERRIDE with system checks goes into recursion and aborts 
related to 0011725closedBrad King CMAKE_USER_MAKE_RULES_OVERRIDE path no longer works if unqualified 
related to 0011724closedBrad King CMAKE_RUNTIME_OUTPUT_DIRECTORY breaks try_compile()'s COPY_FILE directive in 2.8.3 
related to 0011942closedDavid Cole INCLUDE inside file defined by CMAKE_USER_MAKE_RULES_OVERRIDE broken since 2.8.3 

  Notes
(0021187)
Brad King (manager)
2010-06-29 08:39

Thanks for the patch. I've published a fix for VS definitions separation:

  http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=13ca4ef6 [^]

and your patch for CMAKE_USER_MAKE_RULES_OVERRIDE:

  http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=295b5b60 [^]

to the 'next' branch.

 Issue History
Date Modified Username Field Change
2010-06-28 10:19 David Genest New Issue
2010-06-28 10:19 David Genest File Added: cmake_uses_USER_MAKE_RULES_OVERRIDE_in_try_compile.patch
2010-06-28 11:40 Bill Hoffman Status new => assigned
2010-06-28 11:40 Bill Hoffman Assigned To => Brad King
2010-06-29 08:39 Brad King Note Added: 0021187
2010-06-29 08:39 Brad King Status assigned => closed
2010-06-29 08:39 Brad King Resolution open => fixed
2010-09-10 00:06 David Cole Fixed in Version => CMake 2.8.3
2010-09-10 00:06 David Cole Target Version => CMake 2.8.3
2010-11-17 09:53 Brad King Relationship added related to 0011469
2011-01-19 17:47 Brad King Relationship added related to 0011725
2011-01-19 17:48 Brad King Relationship added related to 0011724
2011-03-31 12:35 Brad King Relationship added related to 0011942


Copyright © 2000 - 2018 MantisBT Team