Notes
(0019954) Modestas Vainius (reporter) 2010-03-18 07:34	Well, probably my check is not 100% correct. Looks like it is better to check for the following according to http://glibc-bsd.alioth.debian.org/porting/PORTING [^] since we want to check for userland rather than kernel here: \|\| defined(__GNU__) \|\| defined(__GLIBC__) (__GNU__ being for hurd, __GLIBC__ for kfreebsd) FYI, define dump on kfreebsd-amd64 is as follows: $ gcc -dM -E test.c #define __DBL_MIN_EXP__ (-1021) #define __FLT_MIN__ 1.17549435e-38F #define __CHAR_BIT__ 8 #define __WCHAR_MAX__ 2147483647 #define __GCC_HAVE_SYNC_COMPARE_AND_SWAP_1 1 #define __GCC_HAVE_SYNC_COMPARE_AND_SWAP_2 1 #define __GCC_HAVE_SYNC_COMPARE_AND_SWAP_4 1 #define __DBL_DENORM_MIN__ 4.9406564584124654e-324 #define __GCC_HAVE_SYNC_COMPARE_AND_SWAP_8 1 #define __FLT_EVAL_METHOD__ 0 #define __unix__ 1 #define __x86_64 1 #define __DBL_MIN_10_EXP__ (-307) #define __FINITE_MATH_ONLY__ 0 #define __GNUC_PATCHLEVEL__ 3 #define __DEC64_MAX_EXP__ 385 #define __SHRT_MAX__ 32767 #define __LDBL_MAX__ 1.18973149535723176502e+4932L #define __UINTMAX_TYPE__ long unsigned int #define __DEC32_EPSILON__ 1E-6DF #define __unix 1 #define __LDBL_MAX_EXP__ 16384 #define __SCHAR_MAX__ 127 #define __DBL_DIG__ 15 #define __SIZEOF_INT__ 4 #define __SIZEOF_POINTER__ 8 #define __USER_LABEL_PREFIX__ #define __GLIBC__ 1 #define __STDC_HOSTED__ 1 #define __LDBL_HAS_INFINITY__ 1 #define __FLT_EPSILON__ 1.19209290e-7F #define __LDBL_MIN__ 3.36210314311209350626e-4932L #define __DEC32_MAX__ 9.999999E96DF #define __SIZEOF_LONG__ 8 #define __DECIMAL_DIG__ 21 #define __LDBL_HAS_QUIET_NAN__ 1 #define __GNUC__ 4 #define __MMX__ 1 #define __FLT_HAS_DENORM__ 1 #define __SIZEOF_LONG_DOUBLE__ 16 #define __BIGGEST_ALIGNMENT__ 16 #define __DBL_MAX__ 1.7976931348623157e+308 #define __DBL_HAS_INFINITY__ 1 #define __DEC32_MIN_EXP__ (-94) #define __LDBL_HAS_DENORM__ 1 #define __DEC128_MAX__ 9.999999999999999999999999999999999E6144DL #define __DEC32_MIN__ 1E-95DF #define __DBL_MAX_EXP__ 1024 #define __DEC128_EPSILON__ 1E-33DL #define __SSE2_MATH__ 1 #define __amd64 1 #define __LONG_LONG_MAX__ 9223372036854775807LL #define __SIZEOF_SIZE_T__ 8 #define __SIZEOF_WINT_T__ 4 #define __GCC_HAVE_DWARF2_CFI_ASM 1 #define __GXX_ABI_VERSION 1002 #define __FLT_MIN_EXP__ (-125) #define __DBL_MIN__ 2.2250738585072014e-308 #define __LP64__ 1 #define __DEC128_MIN__ 1E-6143DL #define __REGISTER_PREFIX__ #define __DBL_HAS_DENORM__ 1 #define __NO_INLINE__ 1 #define __FLT_MANT_DIG__ 24 #define __VERSION__ "4.4.3 20100108 (prerelease)" #define __DEC64_EPSILON__ 1E-15DD #define __DEC128_MIN_EXP__ (-6142) #define unix 1 #define __SIZE_TYPE__ long unsigned int #define __ELF__ 1 #define __FLT_RADIX__ 2 #define __LDBL_EPSILON__ 1.08420217248550443401e-19L #define __SSE_MATH__ 1 #define __k8 1 #define __SIZEOF_PTRDIFF_T__ 8 #define __x86_64__ 1 #define __DEC32_SUBNORMAL_MIN__ 0.000001E-95DF #define __FLT_HAS_QUIET_NAN__ 1 #define __FLT_MAX_10_EXP__ 38 #define __LONG_MAX__ 9223372036854775807L #define __DEC128_SUBNORMAL_MIN__ 0.000000000000000000000000000000001E-6143DL #define __FLT_HAS_INFINITY__ 1 #define __DEC64_MAX__ 9.999999999999999E384DD #define __CHAR16_TYPE__ short unsigned int #define __DEC64_MANT_DIG__ 16 #define __DEC32_MAX_EXP__ 97 #define __SSE2__ 1 #define __LDBL_MANT_DIG__ 64 #define __DBL_HAS_QUIET_NAN__ 1 #define __k8__ 1 #define __WCHAR_TYPE__ int #define __SIZEOF_FLOAT__ 4 #define __DEC64_MIN_EXP__ (-382) #define __FLT_DIG__ 6 #define __INT_MAX__ 2147483647 #define __amd64__ 1 #define __FreeBSD_kernel__ 1 #define __FLT_MAX_EXP__ 128 #define __DBL_MANT_DIG__ 53 #define __DEC64_MIN__ 1E-383DD #define __WINT_TYPE__ unsigned int #define __SIZEOF_SHORT__ 2 #define __SSE__ 1 #define __LDBL_MIN_EXP__ (-16381) #define __LDBL_MAX_10_EXP__ 4932 #define __DBL_EPSILON__ 2.2204460492503131e-16 #define _LP64 1 #define __SIZEOF_WCHAR_T__ 4 #define __DEC_EVAL_METHOD__ 2 #define __INTMAX_MAX__ 9223372036854775807L #define __FLT_DENORM_MIN__ 1.40129846e-45F #define __CHAR32_TYPE__ unsigned int #define __FLT_MAX__ 3.40282347e+38F #define __SIZEOF_DOUBLE__ 8 #define __FLT_MIN_10_EXP__ (-37) #define __INTMAX_TYPE__ long int #define __DEC128_MAX_EXP__ 6145 #define __GNUC_MINOR__ 4 #define __DEC32_MANT_DIG__ 7 #define __DBL_MAX_10_EXP__ 308 #define __LDBL_DENORM_MIN__ 3.64519953188247460253e-4951L #define __STDC__ 1 #define __PTRDIFF_TYPE__ long int #define __DEC64_SUBNORMAL_MIN__ 0.000000000000001E-383DD #define __DEC128_MANT_DIG__ 34 #define __LDBL_MIN_10_EXP__ (-4931) #define __SIZEOF_LONG_LONG__ 8 #define __LDBL_DIG__ 18 #define __GNUC_GNU_INLINE__ 1

(0019955) Brad King (manager) 2010-03-18 08:44	Thanks! Fix committed to KWSys: /cvsroot/KWSys/KWSys/ProcessUNIX.c,v <-- ProcessUNIX.c new revision: 1.94; previous revision: 1.93 A robot will replay the change in CMake shortly.

(0019957) Brad King (manager) 2010-03-18 08:58	The fix is now in CMake master: http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=1560d9dc [^]

(0020686) Modestas Vainius (reporter) 2010-05-09 11:24	The patch below adds support for GNU/Hurd and improves support kFreeBSD (uses another predefined macro). It applies on top of the master branch. From 267f63a49652df544ea073cd419ef94b23fa926c Mon Sep 17 00:00:00 2001 From: Modestas Vainius <modestas@vainius.eu> Date: Sun, 9 May 2010 18:15:27 +0300 Subject: [PATCH 1/2] KWSys: improve process tree killing for kFreeBSD and support GNU/Hurd kFreeBSD and Hurd have the same userland as Linux. This change is necessary to enable kwsysProcessKill() to kill child processes on kFreeBSD. The bug was detected by CTestTestTimeout test. Origin: vendor Forwarded: yes Author: Modestas Vainius <modestas@vainius.eu> --- Source/kwsys/ProcessUNIX.c \| 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Source/kwsys/ProcessUNIX.c b/Source/kwsys/ProcessUNIX.c index b368901..9cb787a 100644 --- a/Source/kwsys/ProcessUNIX.c +++ b/Source/kwsys/ProcessUNIX.c @@ -2374,7 +2374,7 @@ static pid_t kwsysProcessFork(kwsysProcess* cp, corresponding parsing format string. The parsing format should have two integers to store: the pid and then the ppid. */ #if defined(__linux__) \|\| defined(__APPLE__) \|\| defined(__FreeBSD__) \ - \|\| defined(__FreeBSD_kernel__) \|\| defined(__OpenBSD__) + \|\| defined(__OpenBSD__) \|\| defined(__GLIBC__) \|\| defined(__GNU__) # define KWSYSPE_PS_COMMAND "ps axo pid,ppid" # define KWSYSPE_PS_FORMAT "%d %d\n" #elif defined(__hpux) \|\| defined(__sun__) \|\| defined(__sgi) \|\| defined(_AIX) \ -- 1.7.1

(0020712) Brad King (manager) 2010-05-11 13:42	Applied: http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=9c0937f8 [^] Thanks. FYI, KWSys is still in CVS and replayed int CMake's Git repository by a robot. That's why I couldn't maintain authorship credit.

Issue History
Date Modified	Username	Field	Change
2010-03-17 20:32	Modestas Vainius	New Issue
2010-03-17 21:39	Bill Hoffman	Status	new => assigned
2010-03-17 21:39	Bill Hoffman	Assigned To	=> Brad King
2010-03-18 07:34	Modestas Vainius	Note Added: 0019954
2010-03-18 08:44	Brad King	Note Added: 0019955
2010-03-18 08:58	Brad King	Note Added: 0019957
2010-03-18 08:58	Brad King	Status	assigned => closed
2010-03-18 08:58	Brad King	Resolution	open => fixed
2010-05-09 11:24	Modestas Vainius	Note Added: 0020686
2010-05-09 11:24	Modestas Vainius	Status	closed => feedback
2010-05-09 11:24	Modestas Vainius	Resolution	fixed => reopened
2010-05-11 13:42	Brad King	Note Added: 0020712
2010-05-11 13:43	Brad King	Status	feedback => closed
2010-05-11 13:43	Brad King	Resolution	reopened => fixed

Relationships