MantisBT - CMake

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0007263

CMake

Modules

public

2008-06-30 11:12

2016-06-10 14:30

Reporter

F Wheeler

Assigned To

Bill Hoffman

Priority

normal

Severity

feature

Reproducibility

always

Status

closed

Resolution

moved

Platform

OS Version

Product Version

CMake-2-6

Target Version

Fixed in Version

Summary

0007263: FindCURL - set required define and dependent library

Description

I've made some improvements to FindCURL.cmake versus the CMake CVS revision 1.4. The comments in the file listed below should explain it all. Here are the two changes:

1. Set CURL_DEFINITIONS are required by the curl library. This I am very sure is the right thing to do. Might need additional extensions in the regep for Mac static libs. I'm not sure how how static libs are names on Macs.

2. Curl depends on wldap32 under Windows. I'm 85% sure this is the right thing to do. libcurl has ldap support by default and would thus need wldap32 under windows. If wldap32 is not available on absolutely every windows system out there then this part of my change might cause problems.

I may continue to make changes. Feel free to email for my latest version wheeler AT research.ge.com.

Here is the entire new file ...

# - Find curl
# Find the native CURL headers and libraries.
#
# CURL_INCLUDE_DIRS - where to find curl/curl.h, etc.
# CURL_LIBRARIES - List of libraries when using curl.
# CURL_DEFINITIONS - Defines required for programs using curl.
# CURL_FOUND - True if curl found.

# Look for the header file.
FIND_PATH(CURL_INCLUDE_DIR NAMES curl/curl.h)
MARK_AS_ADVANCED(CURL_INCLUDE_DIR)

# Look for the library.
FIND_LIBRARY(CURL_LIBRARY NAMES curl)
MARK_AS_ADVANCED(CURL_LIBRARY)

# handle the QUIETLY and REQUIRED arguments and set CURL_FOUND to TRUE if
# all listed variables are TRUE
INCLUDE(FindPackageHandleStandardArgs)
FIND_PACKAGE_HANDLE_STANDARD_ARGS(CURL DEFAULT_MSG CURL_LIBRARY CURL_INCLUDE_DIR)

IF(CURL_FOUND)
  SET(CURL_LIBRARIES ${CURL_LIBRARY})
  SET(CURL_INCLUDE_DIRS ${CURL_INCLUDE_DIR})
ELSE(CURL_FOUND)
  SET(CURL_LIBRARIES)
  SET(CURL_INCLUDE_DIRS)
ENDIF(CURL_FOUND)

IF(CURL_FOUND)

  # Determine whether the CURL library is static/dynamic based on its
  # filename extension.
  SET( CURL_LIBCURL_IS_STATIC NO )
  IF( "${CURL_LIBRARY}" MATCHES "\\.(a|lib|LIB)$" )
    SET( CURL_LIBCURL_IS_STATIC YES )
  ENDIF( "${CURL_LIBRARY}" MATCHES "\\.(a|lib|LIB)$" )

  # CURL requires programs to define CURL_STATICLIB if and only if
  # the CURL library is static. Getting this wrong may result in
  # errors like: "unresolved external symbol __imp__curl_easy_perform"
  SET( CURL_DEFINITIONS "" )
  IF( CURL_LIBCURL_IS_STATIC )
    SET( CURL_DEFINITIONS "-DCURL_STATICLIB" )
  ENDIF( CURL_LIBCURL_IS_STATIC )

  # The CURL library typically depends on wldap32 under Windows.
  # (The library can also be built with out LDAP support.)
  IF( WIN32 )
    SET(CURL_LIBRARIES ${CURL_LIBRARIES} wldap32 )
  ENDIF( WIN32 )

ENDIF(CURL_FOUND)

Steps To Reproduce

Additional Information