MantisBT - CMake
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0016063CMakeCMakepublic2016-04-14 04:402016-06-10 14:31
Reporterxseven 
Assigned ToKitware Robot 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionmoved 
PlatformOSWindowsOS Version10
Product VersionCMake 3.5.1 
Target VersionFixed in Version 
Summary0016063: Wrong protobuf search logic
DescriptionI faced a problem with using find_package(Protobuf).

I'm using protobuf-3.0.0-beta-2

I built it and installed via MSVC 2015 but module looks for
${PROTOBUF_SRC_ROOT_FOLDER}/vsprojects/${_PROTOBUF_ARCH_DIR}Debug)and Release which seem missing in contemporary MSVC build anymore

Could be more reasonable to use PROTOBUF_SRC_ROOT_FOLDER as a path to installed protobuf files after build?
Steps To ReproduceBuild protobuf-3.0.0-beta-2
Set PROTOBUF_SRC_ROOT_FOLDER run CMake 3.5.1
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-04-14 04:40xsevenNew Issue
2016-04-14 14:28Konstantin PodsvirovNote Added: 0040862
2016-04-14 14:29Konstantin PodsvirovNote Edited: 0040862bug_revision_view_page.php?bugnote_id=40862#r2072
2016-06-10 14:29Kitware RobotNote Added: 0042982
2016-06-10 14:29Kitware RobotStatusnew => resolved
2016-06-10 14:29Kitware RobotResolutionopen => moved
2016-06-10 14:29Kitware RobotAssigned To => Kitware Robot
2016-06-10 14:31Kitware RobotStatusresolved => closed

Notes
(0040862)
Konstantin Podsvirov   
2016-04-14 14:28   
(edited on: 2016-04-14 14:29)
Since version 3.0 protobuf project provide CMake project file to build on Windows.
Now standard paths from GNUInstallDirs module is used when installing the project.
Also exported CMake package with the appropriate configuration.
Now you can find a package like this:

find_package(Protobuf CONFIG)

This is compatible with FindProtobuf.cmake module, which was previously used.

Try it.

My PRs on github:

https://github.com/google/protobuf/pulls?q=is%3Apr+author%3Apodsvirov+is%3Aclosed [^]

I guess for a while both versions will coexist. At least, I strive for compatibility.
(0042982)
Kitware Robot   
2016-06-10 14:29   
Resolving issue as `moved`.

This issue tracker is no longer used. Further discussion of this issue may take place in the current CMake Issues page linked in the banner at the top of this page.