MantisBT - CMake
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0014741CMakeModulespublic2014-02-06 21:172014-10-06 10:32
Reporternicolasmartin3d 
Assigned ToStephen Kelly 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionno change required 
PlatformOSOsXOS Version10.9.1
Product Version 
Target VersionFixed in Version 
Summary0014741: FindCXXFeatures (in branch next) does not work
DescriptionHi,

I know the file is not part of current release, but still I think this is a bug if it the file is included as is.
I tested the module FindCXXFeatures.cmake in the branch next, and it did not work.

This is because the file skipped over the check for features, and directly failed.
Changing :
foreach (_cxx_feature IN LISTS CXXFEATURES_FIND_COMPONENTS)
to :
foreach (_cxx_feature IN LISTS CXXFeatures_FIND_COMPONENTS)
did the trick.

I would like to add the check for another feature, in particular for std::thread. Should I open another ticket for this ?
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2014-02-06 21:17nicolasmartin3dNew Issue
2014-02-07 02:22Stephen KellyNote Added: 0035046
2014-02-07 02:22Stephen KellyStatusnew => resolved
2014-02-07 02:22Stephen KellyResolutionopen => no change required
2014-02-07 02:22Stephen KellyAssigned To => Stephen Kelly
2014-10-06 10:32Robert MaynardNote Added: 0036905
2014-10-06 10:32Robert MaynardStatusresolved => closed

Notes
(0035046)
Stephen Kelly   
2014-02-07 02:22   
The approach in that branch is not going to be the approach that eventually gets into master. I have an alternative branch instead with a different approach to the problem

 https://gitorious.org/cmake/steveires-cmake/commits/target_compile_features [^]

The std::thread request should get a new bug report, particularly as it is not a compile feature but a std lib feature.
(0036905)
Robert Maynard   
2014-10-06 10:32   
Closing resolved issues that have not been updated in more than 4 months.