MantisBT - CMake
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0014286CMakeCMakepublic2013-07-11 11:312013-12-02 08:51
ReporterChristian Bühler 
Assigned ToStephen Kelly 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformMicrosoftOSWindowsOS Version7
Product VersionCMake 2.8.11.2 
Target VersionFixed in VersionCMake 2.8.12 
Summary0014286: Regression: ActiveQt is no longer found properly since 2.8.11.1
DescriptionBuilding my project stopped working since v2.8.11.1 because the ActiveQt libraries cannot be found any more.
When going back to 2.8.11, it works fine.
The problem also exists with the latest nightly build (cmake-2.8.11.20130707-gb9c83-win32-x86).
Steps To Reproducecmake_minimum_required(VERSION 2.8)
find_package(Qt4)
message(STATUS ${QT_QAXSERVER_LIBRARY})
Additional InformationOutput with 2.8.11 (how it should be):

-- The C compiler identification is MSVC 16.0.40219.1
-- The CXX compiler identification is MSVC 16.0.40219.1
-- Check for working C compiler: C:/Program Files (x86)/Microsoft Visual Studio 10.0/VC/bin/cl.exe
-- Check for working C compiler: C:/Program Files (x86)/Microsoft Visual Studio 10.0/VC/bin/cl.exe -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working CXX compiler: C:/Program Files (x86)/Microsoft Visual Studio 10.0/VC/bin/cl.exe
-- Check for working CXX compiler: C:/Program Files (x86)/Microsoft Visual Studio 10.0/VC/bin/cl.exe -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Looking for Q_WS_X11
-- Looking for Q_WS_X11 - not found
-- Looking for Q_WS_WIN
-- Looking for Q_WS_WIN - found
-- Looking for Q_WS_QWS
-- Looking for Q_WS_QWS - not found
-- Looking for Q_WS_MAC
-- Looking for Q_WS_MAC - not found
-- Found Qt4: C:/Qt/4.8.5/bin/qmake.exe (found version "4.8.5")
-- optimizedC:/Qt/4.8.5/lib/QAxServer.libdebugC:/Qt/4.8.5/lib/QAxServerd.lib
-- Configuring done
-- Generating done
-- Build files have been written to: D:/tmp/build

Output with 2.8.11.2 (how it is):

-- The C compiler identification is MSVC 16.0.40219.1
-- The CXX compiler identification is MSVC 16.0.40219.1
-- Check for working C compiler: C:/Program Files (x86)/Microsoft Visual Studio 10.0/VC/bin/cl.exe
-- Check for working C compiler: C:/Program Files (x86)/Microsoft Visual Studio 10.0/VC/bin/cl.exe -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working CXX compiler: C:/Program Files (x86)/Microsoft Visual Studio 10.0/VC/bin/cl.exe
-- Check for working CXX compiler: C:/Program Files (x86)/Microsoft Visual Studio 10.0/VC/bin/cl.exe -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Looking for Q_WS_X11
-- Looking for Q_WS_X11 - not found
-- Looking for Q_WS_WIN
-- Looking for Q_WS_WIN - found
-- Looking for Q_WS_QWS
-- Looking for Q_WS_QWS - not found
-- Looking for Q_WS_MAC
-- Looking for Q_WS_MAC - not found
-- Found Qt4: C:/Qt/4.8.5/bin/qmake.exe (found version "4.8.5")
--
-- Configuring done
-- Generating done
-- Build files have been written to: D:/tmp/build
TagsNo tags attached.
Relationships
has duplicate 0014356closed Stephen Kelly QAxServer and QAxContainer are broken in FindQt4.cmake 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2013-07-11 11:31Christian BühlerNew Issue
2013-07-11 12:24Clinton StimpsonNote Added: 0033526
2013-07-17 09:01Clinton StimpsonAssigned To => Stephen Kelly
2013-07-17 09:01Clinton StimpsonStatusnew => assigned
2013-07-22 08:32Stephen KellyNote Added: 0033576
2013-07-23 12:59Christian BühlerNote Added: 0033583
2013-07-24 11:14Stephen KellyNote Added: 0033588
2013-07-24 11:24Christian BühlerNote Added: 0033589
2013-07-24 11:26Stephen KellyNote Added: 0033590
2013-07-24 11:40Christian BühlerNote Added: 0033591
2013-07-24 12:02Stephen KellyNote Added: 0033592
2013-07-25 03:50Christian BühlerNote Added: 0033598
2013-07-25 08:58Stephen KellyNote Added: 0033607
2013-07-25 08:58Stephen KellyStatusassigned => resolved
2013-07-25 08:58Stephen KellyFixed in Version => CMake 2.8.12
2013-07-25 08:58Stephen KellyResolutionopen => fixed
2013-08-14 12:28Stephen KellyRelationship addedhas duplicate 0014356
2013-12-02 08:51Robert MaynardNote Added: 0034657
2013-12-02 08:51Robert MaynardStatusresolved => closed

Notes
(0033526)
Clinton Stimpson   
2013-07-11 12:24   
This was probably caused by
http://cmake.org/gitweb?p=cmake.git;a=commit;h=b8af46cb [^]
(0033576)
Stephen Kelly   
2013-07-22 08:32   
I've pushed the fix-FindQt4-available-modules topic to cmake next. Could you test it out?
(0033583)
Christian Bühler   
2013-07-23 12:59   
I tested with the nightly build cmake-2.8.11.20130722-ge3714-win32-x86, but the problem is still there:

-- The C compiler identification is MSVC 16.0.40219.1
-- The CXX compiler identification is MSVC 16.0.40219.1
-- Check for working C compiler: C:/Program Files (x86)/Microsoft Visual Studio 10.0/VC/bin/cl.exe
-- Check for working C compiler: C:/Program Files (x86)/Microsoft Visual Studio 10.0/VC/bin/cl.exe -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working CXX compiler: C:/Program Files (x86)/Microsoft Visual Studio 10.0/VC/bin/cl.exe
-- Check for working CXX compiler: C:/Program Files (x86)/Microsoft Visual Studio 10.0/VC/bin/cl.exe -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Looking for Q_WS_X11
-- Looking for Q_WS_X11 - not found
-- Looking for Q_WS_WIN
-- Looking for Q_WS_WIN - found
-- Looking for Q_WS_QWS
-- Looking for Q_WS_QWS - not found
-- Looking for Q_WS_MAC
-- Looking for Q_WS_MAC - not found
-- Found Qt4: C:/Qt/4.8.5/bin/qmake.exe (found version "4.8.5")
--
-- Configuring done
-- Generating done
-- Build files have been written to: D:/tmp/build
(0033588)
Stephen Kelly   
2013-07-24 11:14   
Your output doesn't relate to the problem?

Where did you get that nightly build? Are you sure it contained my patch? Can you try to build the cmake master branch or the fix-FindQt4-available-modules branch instead and test that?
(0033589)
Christian Bühler   
2013-07-24 11:24   
Yes, it does relate to the problem, as described in the original bug description.
If this bug was fixed, the fourth line from the bottom would not be empty.

I got that build from http://www.cmake.org/files/dev, [^] which is linked on the cmake download page (http://cmake.org/cmake/resources/software.html [^]).

I am pretty sure, that your patch (5c611402de0f8af1893e36d635b241ed61015949) is included, as this nightly build is based on e371468d0e0890ab810acb1ddfd176424974a09e, which is a child of your patch. So I can see no reason to compile cmake for myself just for testing it.
(0033590)
Stephen Kelly   
2013-07-24 11:26   
Ok. Can you tell what the remaining problem is with the find module?
(0033591)
Christian Bühler   
2013-07-24 11:40   
I'm sorry, but I am not familiar with the cmake source code and do not have the time to dive into it. I can only tell that before 2.8.11.1 it worked fine.
I guess the tiny CMakeLists.txt in "Steps to reproduce" should help you to identify the problem.
(0033592)
Stephen Kelly   
2013-07-24 12:02   
Ok, I've pushed another branch to fix this. Feel free to apply

diff --git a/Modules/FindQt4.cmake b/Modules/FindQt4.cmake
index d821ff9..6e0f69e 100644
--- a/Modules/FindQt4.cmake
+++ b/Modules/FindQt4.cmake
@@ -881,7 +881,7 @@ if (QT_QMAKE_EXECUTABLE AND QTVERSION)
   endforeach()
 
   if(Q_WS_WIN)
- set(QT_MODULES ${QT_MODULES} QAxContainer)
+ set(QT_MODULES ${QT_MODULES} QAxContainer QAxServer)
     # Set QT_AXCONTAINER_INCLUDE_DIR and QT_AXSERVER_INCLUDE_DIR
     find_path(QT_QAXCONTAINER_INCLUDE_DIR ActiveQt
       PATHS ${QT_HEADERS_DIR}/ActiveQt


to your existing nightly instead of waiting for another nightly tomorrow.

Thanks,
(0033598)
Christian Bühler   
2013-07-25 03:50   
Looks good and works fine. Tested with cmake-2.8.11.20130724-g342e-win32-x86.
Thanks.
(0033607)
Stephen Kelly   
2013-07-25 08:58   
Thanks for testing.
(0034657)
Robert Maynard   
2013-12-02 08:51   
Closing resolved issues that have not been updated in more than 4 months.