MantisBT - CMake
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0010902CMakeCMakepublic2010-06-28 10:192010-09-10 00:06
ReporterDavid Genest 
Assigned ToBrad King 
PrioritynormalSeverityblockReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product VersionCMake-2-8 
Target VersionCMake 2.8.3Fixed in VersionCMake 2.8.3 
Summary0010902: USER_MAKE_RULES_OVERRIDE variable is not used in initial try_compile
DescriptionI am modifying the toolchain used to create a build on PlayStation 3 using the USER_MAKE_RULES_OVERRIDE variable. This variable is not taken into account in the try_compile that cmake generates and runs to verify the toolchain. Cmake fails on linking because some windows specific link commands get added to the build. (PS3 builds are made through an integration with visual studio so some parts get detected as a windows-cl platform which it is not.)

The attached patch also contains a fix for generating valid build files on ps3: the comma separator between defines is not supported in a ps3 build, and by experimentation, the semicolon fixes it and is also supported by visual studio 9 2008 and by memory it works also on 2005.
Steps To Reproduce
Additional InformationThe patch is against 2.8.0, but I checked the gitweb repo and the related files have not changed in 2.8.1
TagsNo tags attached.
Relationships
related to 0011469closed Brad King CMAKE_USER_MAKE_RULES_OVERRIDE with system checks goes into recursion and aborts 
related to 0011725closed Brad King CMAKE_USER_MAKE_RULES_OVERRIDE path no longer works if unqualified 
related to 0011724closed Brad King CMAKE_RUNTIME_OUTPUT_DIRECTORY breaks try_compile()'s COPY_FILE directive in 2.8.3 
related to 0011942closed David Cole INCLUDE inside file defined by CMAKE_USER_MAKE_RULES_OVERRIDE broken since 2.8.3 
Attached Filespatch cmake_uses_USER_MAKE_RULES_OVERRIDE_in_try_compile.patch (1,561) 2010-06-28 10:19
https://public.kitware.com/Bug/file/3213/cmake_uses_USER_MAKE_RULES_OVERRIDE_in_try_compile.patch
Issue History
Date ModifiedUsernameFieldChange
2010-06-28 10:19David GenestNew Issue
2010-06-28 10:19David GenestFile Added: cmake_uses_USER_MAKE_RULES_OVERRIDE_in_try_compile.patch
2010-06-28 11:40Bill HoffmanStatusnew => assigned
2010-06-28 11:40Bill HoffmanAssigned To => Brad King
2010-06-29 08:39Brad KingNote Added: 0021187
2010-06-29 08:39Brad KingStatusassigned => closed
2010-06-29 08:39Brad KingResolutionopen => fixed
2010-09-10 00:06David ColeFixed in Version => CMake 2.8.3
2010-09-10 00:06David ColeTarget Version => CMake 2.8.3
2010-11-17 09:53Brad KingRelationship addedrelated to 0011469
2011-01-19 17:47Brad KingRelationship addedrelated to 0011725
2011-01-19 17:48Brad KingRelationship addedrelated to 0011724
2011-03-31 12:35Brad KingRelationship addedrelated to 0011942

Notes
(0021187)
Brad King   
2010-06-29 08:39   
Thanks for the patch. I've published a fix for VS definitions separation:

  http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=13ca4ef6 [^]

and your patch for CMAKE_USER_MAKE_RULES_OVERRIDE:

  http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=295b5b60 [^]

to the 'next' branch.